]> git.ipfire.org Git - thirdparty/krb5.git/commitdiff
Avoid uninitialized data in t_prf.c 250/head
authorTom Yu <tlyu@mit.edu>
Wed, 4 Feb 2015 22:01:14 +0000 (17:01 -0500)
committerTom Yu <tlyu@mit.edu>
Wed, 4 Feb 2015 22:50:23 +0000 (17:50 -0500)
In t_prf.c, make sure that the partially initialized, faked-up
structures gss_union_ctx_id_desc and krb5_gss_ctx_id_rec are zeroed.
This avoids uninitialized reads in gss_pseudo_random(), which can
cause intermittent test failures on some platforms.

ticket: 8072 (new)
target_version: 1.13.1
tags: pullup

src/tests/gssapi/t_prf.c

index 7f0489995ed5bd4dc574fb1a8a95cc874df1c0af..082edff93478b54f8996fbd5a37b0da8b2a3a2c0 100644 (file)
@@ -124,8 +124,10 @@ main(int argc, char *argv[])
      * implementation.
      */
     context = (gss_ctx_id_t)&uctx;
+    memset(&uctx, 0, sizeof(uctx));
     uctx.mech_type = &mech_krb5;
     uctx.internal_ctx_id = (gss_ctx_id_t)&kgctx;
+    memset(&kgctx, 0, sizeof(kgctx));
     kgctx.k5_context = NULL;
     kgctx.established = 1;
     kgctx.have_acceptor_subkey = 1;