]> git.ipfire.org Git - thirdparty/sqlalchemy/sqlalchemy.git/commitdiff
correct PR
authorPablo Nicolas Estevez <pablo22estevez@gmail.com>
Sun, 1 Dec 2024 20:34:27 +0000 (17:34 -0300)
committerPablo Nicolas Estevez <pablo22estevez@gmail.com>
Sun, 1 Dec 2024 20:34:27 +0000 (17:34 -0300)
lib/sqlalchemy/dialects/mysql/base.py
test/orm/dml/test_update_delete_where.py

index 282e36a0841da4b16b3b823ad3183f48873d024d..5bd9300b7a12a15732df283f86968cb719dc41fa 100644 (file)
@@ -473,6 +473,8 @@ available.
 
     update(..., mysql_limit=10, mariadb_limit=10)
 
+.. versionadded:: 2.1 Added delete with limit
+
 * DELETE with LIMIT::
 
     delete(..., mysql_limit=10, mariadb_limit=10)
index daa2d5bd0c641a968c50e53e075829364e2b5479..7d06a8618cd44440c9d45d4905ac4bfb1c66cca4 100644 (file)
@@ -2585,29 +2585,8 @@ class UpdateDeleteFromTest(fixtures.MappedTest):
             ],
         )
 
-    def test_delete_args(self):
-        Data = self.classes.Data
-        session = fixture_session()
-        delete_args = {"mysql_limit": 1}
-
-        m1 = testing.mock.Mock()
-
-        @event.listens_for(session, "after_bulk_update")
-        def do_orm_execute(bulk_ud):
-            delete_stmt = (
-                bulk_ud.result.context.compiled.compile_state.statement
-            )
-            m1(delete_stmt)
-
-        q = session.query(Data)
-        q.delete(delete_args=delete_args)
-
-        delete_stmt = m1.mock_calls[0][1][0]
-
-        eq_(delete_stmt.dialect_kwargs, delete_args)
-
 
-class ExpressionUpdateTest(fixtures.MappedTest):
+class ExpressionUpdateDeleteTest(fixtures.MappedTest):
     @classmethod
     def define_tables(cls, metadata):
         Table(
@@ -2673,6 +2652,27 @@ class ExpressionUpdateTest(fixtures.MappedTest):
 
         eq_(update_stmt.dialect_kwargs, update_args)
 
+    def test_delete_args(self):
+        Data = self.classes.Data
+        session = fixture_session()
+        delete_args = {"mysql_limit": 1}
+
+        m1 = testing.mock.Mock()
+
+        @event.listens_for(session, "after_bulk_delete")
+        def do_orm_execute(bulk_ud):
+            delete_stmt = (
+                bulk_ud.result.context.compiled.compile_state.statement
+            )
+            m1(delete_stmt)
+
+        q = session.query(Data)
+        q.delete(delete_args=delete_args)
+
+        delete_stmt = m1.mock_calls[0][1][0]
+
+        eq_(delete_stmt.dialect_kwargs, delete_args)
+
 
 class InheritTest(fixtures.DeclarativeMappedTest):
     run_inserts = "each"