]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
RDMA/irdma: Fix typo in SQ completions generation
authorCyrill Gorcunov <gorcunov@gmail.com>
Thu, 28 May 2026 22:30:11 +0000 (01:30 +0300)
committerJason Gunthorpe <jgg@nvidia.com>
Wed, 3 Jun 2026 18:05:29 +0000 (15:05 -0300)
When we generate completion for SQ the opcode while being properly read
from ring buffer is ignored when written back to completion. Seems
to be a simple typo.

Link: https://patch.msgid.link/r/ahjB87k54bYdFbft@grain
Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
Reviewed-by: Jacob Moroni <jmoroni@google.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
drivers/infiniband/hw/irdma/utils.c

index 495e5daff4b457610aebc8989801f65c19f46799..7cc7b107db3cc1a9657ad56cc11a8819bd0e305d 100644 (file)
@@ -2442,7 +2442,7 @@ void irdma_generate_flush_completions(struct irdma_qp *iwqp)
                        cmpl->cpi.wr_id = qp->sq_wrtrk_array[wqe_idx].wrid;
                        sw_wqe = qp->sq_base[wqe_idx].elem;
                        get_64bit_val(sw_wqe, 24, &wqe_qword);
-                       cmpl->cpi.op_type = (u8)FIELD_GET(IRDMAQPSQ_OPCODE, IRDMAQPSQ_OPCODE);
+                       cmpl->cpi.op_type = (u8)FIELD_GET(IRDMAQPSQ_OPCODE, wqe_qword);
                        cmpl->cpi.q_type = IRDMA_CQE_QTYPE_SQ;
                        /* remove the SQ WR by moving SQ tail*/
                        IRDMA_RING_SET_TAIL(*sq_ring,