lmtp: lmtp-client - Fix potential segfault occurring at service termination

Invalid write of size 8 found by Valgrind.
Broken by 9a1a1cc222d7b67abf3ff621b70ed92b1b6d8d39.

diff --git a/src/lmtp/lmtp-client.c b/src/lmtp/lmtp-client.c
index 3ac84737b371db55ff2ecfa7682f42d2a191d20b..a7669d20c2c8a3cbad79179610f32f8ee5e98367 100644 (file)
--- a/src/lmtp/lmtp-client.c
+++ b/src/lmtp/lmtp-client.c
@@ -270,12 +270,14 @@ void client_destroy(struct client **_client, const char *enh_code,
 
        *_client = NULL;
 
+       client_ref(client);
        smtp_server_connection_terminate(&conn,
                (enh_code == NULL ? "4.0.0" : enh_code), reason);
        /* smtp_server_connection_terminate() calls
           client_connection_state_changed(), which may still access
           client->conn. Don't clear it before that. */
        client->conn = NULL;
+       client_unref(&client);
 }
 
 static void