]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s3:registry: Add missing return value checks
authorAndreas Schneider <asn@samba.org>
Wed, 19 Jun 2024 09:47:41 +0000 (11:47 +0200)
committerAndreas Schneider <asn@cryptomilk.org>
Mon, 24 Jun 2024 06:14:36 +0000 (06:14 +0000)
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Signed-off-by: Martin Schwenke <mschwenke@ddn.com>
source3/registry/reg_perfcount.c

index 6c8d7e83ede79a4791ff7dc0bd95b883ec9968c8..7be0a1b0147627a45108dbf4e52fd89e05d80d4d 100644 (file)
@@ -262,6 +262,9 @@ uint32_t reg_perfcount_get_counter_help(uint32_t base_index, char **retbuf)
        for(i = 1; i <= base_index; i++)
        {
                buffer_size = _reg_perfcount_multi_sz_from_tdb(names, (i*2)+1, retbuf, buffer_size);
+               if (buffer_size == 0) {
+                       return buffer_size;
+               }
        }
        tdb_close(names);
 
@@ -310,10 +313,16 @@ uint32_t reg_perfcount_get_counter_names(uint32_t base_index, char **retbuf)
        TALLOC_FREE(fname);
 
        buffer_size = _reg_perfcount_multi_sz_from_tdb(names, 1, retbuf, buffer_size);
+       if (buffer_size == 0) {
+               return buffer_size;
+       }
 
        for(i = 1; i <= base_index; i++)
        {
                buffer_size = _reg_perfcount_multi_sz_from_tdb(names, i*2, retbuf, buffer_size);
+               if (buffer_size == 0) {
+                       return buffer_size;
+               }
        }
        tdb_close(names);