string list: Need to strdup return value on remove first.

The id is part of the buffer itself (rather than separately
allocated), so need to strdup the id when returning first
element.

diff --git a/src/string_list.c b/src/string_list.c
index 000d9cc9d498c3748a40ec687dc2682065bb3adb..2d851bf28d6549cc16651f47e7fa0f28d6020542 100644 (file)
--- a/src/string_list.c
+++ b/src/string_list.c
@@ -58,7 +58,7 @@ string_list_remove_first(string_list_t *l)
   string_list_item_t *item = RB_FIRST(l);
   if (!item)
     return NULL;
-  ret = item->id;
+  ret = strdup(item->id);
   RB_REMOVE(l, item, h_link);
   free(item);
   return ret;