]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
auxdisplay: arm-charlcd: fix release_mem_region() size
authorThomas Fourier <fourier.thomas@gmail.com>
Tue, 16 Dec 2025 17:47:13 +0000 (18:47 +0100)
committerAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Mon, 29 Dec 2025 12:41:08 +0000 (13:41 +0100)
It seems like, after the request_mem_region(), the corresponding
release_mem_region() must take the same size. This was done
in (now removed due to previous refactoring) charlcd_remove()
but not in the error path in charlcd_probe().

Fixes: ce8962455e90 ("ARM: 6214/2: driver for the character LCD found in ARM refdesigns")
Signed-off-by: Thomas Fourier <fourier.thomas@gmail.com>
Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
drivers/auxdisplay/arm-charlcd.c

index a7eae99a48f77d53de52132aed1640d6fd8fbcf5..4e22882f57c9c2cdbc08b2ee6486e04577df8dda 100644 (file)
@@ -323,7 +323,7 @@ static int __init charlcd_probe(struct platform_device *pdev)
 out_no_irq:
        iounmap(lcd->virtbase);
 out_no_memregion:
-       release_mem_region(lcd->phybase, SZ_4K);
+       release_mem_region(lcd->phybase, lcd->physize);
 out_no_resource:
        kfree(lcd);
        return ret;