Stop xmlFreeTextWriter being called twice

xmlFreeTextWriter could be called twice if xmlDocDumpFormatMemoryEnc
failed.

diff --git a/bin/named/statschannel.c b/bin/named/statschannel.c
index bb46479b6423be7a055932818147d919d60b36fa..d2cfc12bf5c5eb92d4bdf33c7d856c85eb502eac 100644 (file)
--- a/bin/named/statschannel.c
+++ b/bin/named/statschannel.c
@@ -2336,12 +2336,12 @@ generatexml(named_server_t *server, uint32_t flags, int *buflen,
        TRY0(xmlTextWriterEndElement(writer)); /* /statistics */
        TRY0(xmlTextWriterEndDocument(writer));
 
-       xmlFreeTextWriter(writer);
-
        xmlDocDumpFormatMemoryEnc(doc, buf, buflen, "UTF-8", 0);
        if (*buf == NULL) {
                goto cleanup;
        }
+
+       xmlFreeTextWriter(writer);
        xmlFreeDoc(doc);
        return (ISC_R_SUCCESS);