]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/bridge: tda998x: Return NULL instead of 0 in tda998x_edid_read()
authorKory Maincent (TI) <kory.maincent@bootlin.com>
Fri, 17 Apr 2026 15:54:45 +0000 (17:54 +0200)
committerLuca Ceresoli <luca.ceresoli@bootlin.com>
Mon, 4 May 2026 14:52:40 +0000 (16:52 +0200)
tda998x_edid_read() returns a const struct drm_edid pointer, but when
tda998x_edid_delay_wait() fails (process killed while waiting for the
HPD timeout), the integer literal 0 is returned instead of NULL,
triggering a sparse warning: "Using plain integer as NULL pointer"

Replace 0 with NULL to fix the sparse warning.

Fixes: c76a8be4feec ("drm/bridge: tda998x: Add support for DRM_BRIDGE_ATTACH_NO_CONNECTOR")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202604172257.Imo6GOH9-lkp@intel.com/
Signed-off-by: Kory Maincent (TI) <kory.maincent@bootlin.com>
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Link: https://patch.msgid.link/20260417155446.1068893-1-kory.maincent@bootlin.com
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
drivers/gpu/drm/bridge/tda998x_drv.c

index 779b976f601c1f10150e3840f8e2f989c61a6d3c..6c427bc75896bc28733ba4bff06c68daebf4dd2d 100644 (file)
@@ -1293,7 +1293,7 @@ static const struct drm_edid *tda998x_edid_read(struct tda998x_priv *priv,
         * can't handle signals gracefully.
         */
        if (tda998x_edid_delay_wait(priv))
-               return 0;
+               return NULL;
 
        if (priv->rev == TDA19988)
                reg_clear(priv, REG_TX4, TX4_PD_RAM);