BUILD: pool: Fix GCC error about potential null pointer dereference

In pool_gc(), GCC 13.2.1 reports an error about a potential null potential
dereference:

src/pool.c: In function ‘pool_gc’:
src/pool.c:807:64: error: potential null pointer dereference [-Werror=null-dereference]
  807 |                         entry->buckets[bucket].free_list = temp->next;
      |                                                            ~~~~^~~~~~

There is no issue here because "bucket" variable cannot be greater than
CONFIG_HAP_POOL_BUCKETS. But to make GCC happy, we now break the loop if it
is greater or equal to CONFIG_HAP_POOL_BUCKETS.

diff --git a/src/pool.c b/src/pool.c
index 2f20fd55537ed9c9f7328e177f9831ca5631405c..964421fee6358b086715097b7ce14e12dfa74f29 100644 (file)
--- a/src/pool.c
+++ b/src/pool.c
@@ -800,7 +800,7 @@ void pool_gc(struct pool_head *pool_ctx)
                        while (!entry->buckets[bucket].free_list && bucket < CONFIG_HAP_POOL_BUCKETS)
                                bucket++;
 
-                       if (bucket == CONFIG_HAP_POOL_BUCKETS)
+                       if (bucket >= CONFIG_HAP_POOL_BUCKETS)
                                break;
 
                        temp = entry->buckets[bucket].free_list;