affs: Drop support for metadata bh tracking

AFFS did all the hard work of tracking metadata bhs dirtied for an inode
but it actually never used this information as affs_file_fsync() just
calls sync_blockdev() to writeback all filesystem metadata bhs. After a
discussion with AFFS maintainer nobody cares about AFFS performance
so let's keep this affs_file_fsync() behavior and just drop all the
pointless tracking from AFFS.

CC: David Sterba <dsterba@suse.com>
Acked-by: David Sterba <dsterba@suse.com>
Signed-off-by: Jan Kara <jack@suse.cz>
Link: https://patch.msgid.link/20260727104923.3828017-21-jack@suse.cz
Signed-off-by: Christian Brauner (Amutable) <brauner@kernel.org>

diff --git a/fs/affs/affs.h b/fs/affs/affs.h
index 44a3f69d275f96359c7628b0b90de1a1b7a77947..a7faa91deed5ac2c9da995992956e924f68f6f72 100644 (file)
--- a/fs/affs/affs.h
+++ b/fs/affs/affs.h
@@ -44,7 +44,6 @@ struct affs_inode_info {
        struct mutex i_link_lock;               /* Protects internal inode access. */
        struct mutex i_ext_lock;                /* Protects internal inode access. */
 #define i_hash_lock i_ext_lock
-       struct mapping_metadata_bhs i_metadata_bhs;
        u32      i_blkcnt;                      /* block count */
        u32      i_extcnt;                      /* extended block count */
        u32     *i_lc;                          /* linear cache of extended blocks */
@@ -152,7 +151,6 @@ extern bool affs_nofilenametruncate(const struct dentry *dentry);
 extern int     affs_check_name(const unsigned char *name, int len,
                                bool notruncate);
 extern int     affs_copy_name(unsigned char *bstr, struct dentry *dentry);
-struct mapping_metadata_bhs *affs_get_metadata_bhs(struct inode *inode);
 
 /* bitmap. c */
 

diff --git a/fs/affs/amigaffs.c b/fs/affs/amigaffs.c
index bed4fc805e8e669bea08b70216442f10a3911686..6cc0fc9a4cbf92d6082f808f59789ce17a862e50 100644 (file)
--- a/fs/affs/amigaffs.c
+++ b/fs/affs/amigaffs.c
@@ -57,7 +57,7 @@ affs_insert_hash(struct inode *dir, struct buffer_head *bh)
                AFFS_TAIL(sb, dir_bh)->hash_chain = cpu_to_be32(ino);
 
        affs_adjust_checksum(dir_bh, ino);
-       mmb_mark_buffer_dirty(dir_bh, &AFFS_I(dir)->i_metadata_bhs);
+       mark_buffer_dirty(dir_bh);
        affs_brelse(dir_bh);
 
        inode_set_mtime_to_ts(dir, inode_set_ctime_current(dir));
@@ -100,7 +100,7 @@ affs_remove_hash(struct inode *dir, struct buffer_head *rem_bh)
                        else
                                AFFS_TAIL(sb, bh)->hash_chain = ino;
                        affs_adjust_checksum(bh, be32_to_cpu(ino) - hash_ino);
-                       mmb_mark_buffer_dirty(bh, &AFFS_I(dir)->i_metadata_bhs);
+                       mark_buffer_dirty(bh);
                        AFFS_TAIL(sb, rem_bh)->parent = 0;
                        retval = 0;
                        break;
@@ -180,7 +180,7 @@ affs_remove_link(struct dentry *dentry)
                        affs_unlock_dir(dir);
                        goto done;
                }
-               mmb_mark_buffer_dirty(link_bh, &AFFS_I(inode)->i_metadata_bhs);
+               mark_buffer_dirty(link_bh);
 
                memcpy(AFFS_TAIL(sb, bh)->name, AFFS_TAIL(sb, link_bh)->name, 32);
                retval = affs_insert_hash(dir, bh);
@@ -188,7 +188,7 @@ affs_remove_link(struct dentry *dentry)
                        affs_unlock_dir(dir);
                        goto done;
                }
-               mmb_mark_buffer_dirty(bh, &AFFS_I(inode)->i_metadata_bhs);
+               mark_buffer_dirty(bh);
 
                affs_unlock_dir(dir);
                iput(dir);
@@ -203,7 +203,7 @@ affs_remove_link(struct dentry *dentry)
                        __be32 ino2 = AFFS_TAIL(sb, link_bh)->link_chain;
                        AFFS_TAIL(sb, bh)->link_chain = ino2;
                        affs_adjust_checksum(bh, be32_to_cpu(ino2) - link_ino);
-                       mmb_mark_buffer_dirty(bh, &AFFS_I(inode)->i_metadata_bhs);
+                       mark_buffer_dirty(bh);
                        retval = 0;
                        /* Fix the link count, if bh is a normal header block without links */
                        switch (be32_to_cpu(AFFS_TAIL(sb, bh)->stype)) {
@@ -306,7 +306,7 @@ affs_remove_header(struct dentry *dentry)
        retval = affs_remove_hash(dir, bh);
        if (retval)
                goto done_unlock;
-       mmb_mark_buffer_dirty(bh, &AFFS_I(inode)->i_metadata_bhs);
+       mark_buffer_dirty(bh);
 
        affs_unlock_dir(dir);
 

diff --git a/fs/affs/file.c b/fs/affs/file.c
index 144b17482d12dabd8254c911a306d873b174c8b9..23e088a7ed4fb30b0befae53d0cbeabb1a1ee866 100644 (file)
--- a/fs/affs/file.c
+++ b/fs/affs/file.c
@@ -140,14 +140,14 @@ affs_alloc_extblock(struct inode *inode, struct buffer_head *bh, u32 ext)
        AFFS_TAIL(sb, new_bh)->parent = cpu_to_be32(inode->i_ino);
        affs_fix_checksum(sb, new_bh);
 
-       mmb_mark_buffer_dirty(new_bh, &AFFS_I(inode)->i_metadata_bhs);
+       mark_buffer_dirty(new_bh);
 
        tmp = be32_to_cpu(AFFS_TAIL(sb, bh)->extension);
        if (tmp)
                affs_warning(sb, "alloc_ext", "previous extension set (%x)", tmp);
        AFFS_TAIL(sb, bh)->extension = cpu_to_be32(blocknr);
        affs_adjust_checksum(bh, blocknr - tmp);
-       mmb_mark_buffer_dirty(bh, &AFFS_I(inode)->i_metadata_bhs);
+       mark_buffer_dirty(bh);
 
        AFFS_I(inode)->i_extcnt++;
        mark_inode_dirty(inode);
@@ -581,7 +581,7 @@ affs_extent_file_ofs(struct inode *inode, u32 newsize)
                memset(AFFS_DATA(bh) + boff, 0, tmp);
                be32_add_cpu(&AFFS_DATA_HEAD(bh)->size, tmp);
                affs_fix_checksum(sb, bh);
-               mmb_mark_buffer_dirty(bh, &AFFS_I(inode)->i_metadata_bhs);
+               mark_buffer_dirty(bh);
                size += tmp;
                bidx++;
        } else if (bidx) {
@@ -603,7 +603,7 @@ affs_extent_file_ofs(struct inode *inode, u32 newsize)
                AFFS_DATA_HEAD(bh)->size = cpu_to_be32(tmp);
                affs_fix_checksum(sb, bh);
                bh->b_state &= ~(1UL << BH_New);
-               mmb_mark_buffer_dirty(bh, &AFFS_I(inode)->i_metadata_bhs);
+               mark_buffer_dirty(bh);
                if (prev_bh) {
                        u32 tmp_next = be32_to_cpu(AFFS_DATA_HEAD(prev_bh)->next);
 
@@ -613,8 +613,7 @@ affs_extent_file_ofs(struct inode *inode, u32 newsize)
                                             bidx, tmp_next);
                        AFFS_DATA_HEAD(prev_bh)->next = cpu_to_be32(bh->b_blocknr);
                        affs_adjust_checksum(prev_bh, bh->b_blocknr - tmp_next);
-                       mmb_mark_buffer_dirty(prev_bh,
-                                             &AFFS_I(inode)->i_metadata_bhs);
+                       mark_buffer_dirty(prev_bh);
                        affs_brelse(prev_bh);
                }
                size += bsize;
@@ -733,7 +732,7 @@ static int affs_write_end_ofs(const struct kiocb *iocb,
                AFFS_DATA_HEAD(bh)->size = cpu_to_be32(
                        max(boff + tmp, be32_to_cpu(AFFS_DATA_HEAD(bh)->size)));
                affs_fix_checksum(sb, bh);
-               mmb_mark_buffer_dirty(bh, &AFFS_I(inode)->i_metadata_bhs);
+               mark_buffer_dirty(bh);
                written += tmp;
                from += tmp;
                bidx++;
@@ -766,13 +765,12 @@ static int affs_write_end_ofs(const struct kiocb *iocb,
                                                     bidx, tmp_next);
                                AFFS_DATA_HEAD(prev_bh)->next = cpu_to_be32(bh->b_blocknr);
                                affs_adjust_checksum(prev_bh, bh->b_blocknr - tmp_next);
-                               mmb_mark_buffer_dirty(prev_bh,
-                                       &AFFS_I(inode)->i_metadata_bhs);
+                               mark_buffer_dirty(prev_bh);
                        }
                }
                affs_brelse(prev_bh);
                affs_fix_checksum(sb, bh);
-               mmb_mark_buffer_dirty(bh, &AFFS_I(inode)->i_metadata_bhs);
+               mark_buffer_dirty(bh);
                written += bsize;
                from += bsize;
                bidx++;
@@ -801,14 +799,13 @@ static int affs_write_end_ofs(const struct kiocb *iocb,
                                                     bidx, tmp_next);
                                AFFS_DATA_HEAD(prev_bh)->next = cpu_to_be32(bh->b_blocknr);
                                affs_adjust_checksum(prev_bh, bh->b_blocknr - tmp_next);
-                               mmb_mark_buffer_dirty(prev_bh,
-                                               &AFFS_I(inode)->i_metadata_bhs);
+                               mark_buffer_dirty(prev_bh);
                        }
                } else if (be32_to_cpu(AFFS_DATA_HEAD(bh)->size) < tmp)
                        AFFS_DATA_HEAD(bh)->size = cpu_to_be32(tmp);
                affs_brelse(prev_bh);
                affs_fix_checksum(sb, bh);
-               mmb_mark_buffer_dirty(bh, &AFFS_I(inode)->i_metadata_bhs);
+               mark_buffer_dirty(bh);
                written += tmp;
                from += tmp;
                bidx++;
@@ -945,7 +942,7 @@ affs_truncate(struct inode *inode)
        }
        AFFS_TAIL(sb, ext_bh)->extension = 0;
        affs_fix_checksum(sb, ext_bh);
-       mmb_mark_buffer_dirty(ext_bh, &AFFS_I(inode)->i_metadata_bhs);
+       mark_buffer_dirty(ext_bh);
        affs_brelse(ext_bh);
 
        if (inode->i_size) {

diff --git a/fs/affs/inode.c b/fs/affs/inode.c
index 5dd1b016bcb00a572ca68d0172a035d2cb05c7d8..d4a3f381c4bcff616fa6d8f55b99256d4eed7014 100644 (file)
--- a/fs/affs/inode.c
+++ b/fs/affs/inode.c
@@ -206,7 +206,7 @@ affs_write_inode(struct inode *inode, struct writeback_control *wbc)
                }
        }
        affs_fix_checksum(sb, bh);
-       mmb_mark_buffer_dirty(bh, &AFFS_I(inode)->i_metadata_bhs);
+       mark_buffer_dirty(bh);
        affs_brelse(bh);
        affs_free_prealloc(inode);
        return 0;
@@ -266,11 +266,8 @@ affs_evict_inode(struct inode *inode)
        if (!inode->i_nlink) {
                inode->i_size = 0;
                affs_truncate(inode);
-       } else {
-               mmb_sync(&AFFS_I(inode)->i_metadata_bhs);
        }
 
-       mmb_invalidate(&AFFS_I(inode)->i_metadata_bhs);
        clear_inode(inode);
        affs_free_prealloc(inode);
        cache_page = (unsigned long)AFFS_I(inode)->i_lc;
@@ -305,7 +302,7 @@ affs_new_inode(struct inode *dir)
        bh = affs_getzeroblk(sb, block);
        if (!bh)
                goto err_bh;
-       mmb_mark_buffer_dirty(bh, &AFFS_I(inode)->i_metadata_bhs);
+       mark_buffer_dirty(bh);
        affs_brelse(bh);
 
        inode->i_uid     = current_fsuid();
@@ -393,17 +390,17 @@ affs_add_entry(struct inode *dir, struct inode *inode, struct dentry *dentry, s3
                AFFS_TAIL(sb, bh)->link_chain = chain;
                AFFS_TAIL(sb, inode_bh)->link_chain = cpu_to_be32(block);
                affs_adjust_checksum(inode_bh, block - be32_to_cpu(chain));
-               mmb_mark_buffer_dirty(inode_bh, &AFFS_I(inode)->i_metadata_bhs);
+               mark_buffer_dirty(inode_bh);
                set_nlink(inode, 2);
                ihold(inode);
        }
        affs_fix_checksum(sb, bh);
-       mmb_mark_buffer_dirty(bh, &AFFS_I(inode)->i_metadata_bhs);
+       mark_buffer_dirty(bh);
        dentry->d_fsdata = (void *)(long)bh->b_blocknr;
 
        affs_lock_dir(dir);
        retval = affs_insert_hash(dir, bh);
-       mmb_mark_buffer_dirty(bh, &AFFS_I(inode)->i_metadata_bhs);
+       mark_buffer_dirty(bh);
        affs_unlock_dir(dir);
        affs_unlock_link(inode);
 

diff --git a/fs/affs/namei.c b/fs/affs/namei.c
index c3c6532da4b0da3e332d211c9261ab711ea3a3c5..57d8d755aada052e65b581677ad4028a9958e9c6 100644 (file)
--- a/fs/affs/namei.c
+++ b/fs/affs/namei.c
@@ -373,7 +373,7 @@ affs_symlink(struct mnt_idmap *idmap, struct inode *dir,
        }
        *p = 0;
        inode->i_size = i + 1;
-       mmb_mark_buffer_dirty(bh, &AFFS_I(inode)->i_metadata_bhs);
+       mark_buffer_dirty(bh);
        affs_brelse(bh);
        mark_inode_dirty(inode);
 
@@ -443,8 +443,7 @@ affs_rename(struct inode *old_dir, struct dentry *old_dentry,
        /* TODO: move it back to old_dir, if error? */
 
 done:
-       mmb_mark_buffer_dirty(bh,
-                       &AFFS_I(retval ? old_dir : new_dir)->i_metadata_bhs);
+       mark_buffer_dirty(bh);
        affs_brelse(bh);
        return retval;
 }
@@ -497,8 +496,8 @@ affs_xrename(struct inode *old_dir, struct dentry *old_dentry,
        retval = affs_insert_hash(old_dir, bh_new);
        affs_unlock_dir(old_dir);
 done:
-       mmb_mark_buffer_dirty(bh_old, &AFFS_I(new_dir)->i_metadata_bhs);
-       mmb_mark_buffer_dirty(bh_new, &AFFS_I(old_dir)->i_metadata_bhs);
+       mark_buffer_dirty(bh_old);
+       mark_buffer_dirty(bh_new);
        affs_brelse(bh_old);
        affs_brelse(bh_new);
        return retval;

diff --git a/fs/affs/super.c b/fs/affs/super.c
index b232251aa7bbd008aeb758b5c94fe8674691268a..0ad5127e9fb8ee354a42717f22686454395acb17 100644 (file)
--- a/fs/affs/super.c
+++ b/fs/affs/super.c
@@ -108,7 +108,6 @@ static struct inode *affs_alloc_inode(struct super_block *sb)
        i->i_lc = NULL;
        i->i_ext_bh = NULL;
        i->i_pa_cnt = 0;
-       mmb_init(&i->i_metadata_bhs, &i->vfs_inode.i_data);
 
        return &i->vfs_inode;
 }