]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
phy: renesas: rcar-gen2: Simplify with scoped for each OF child loop
authorKrzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Wed, 24 Dec 2025 12:44:10 +0000 (13:44 +0100)
committerVinod Koul <vkoul@kernel.org>
Thu, 1 Jan 2026 10:58:56 +0000 (16:28 +0530)
Use scoped for-each loop when iterating over device nodes to make code a
bit simpler.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Link: https://patch.msgid.link/20251224124407.208354-6-krzysztof.kozlowski@oss.qualcomm.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/renesas/phy-rcar-gen2.c

index 08d36e6eabcd6262f8364175627291c81b07a97a..6c671254c6258010e6f103c41d4e64e09835d4c8 100644 (file)
@@ -337,7 +337,6 @@ static int rcar_gen2_phy_probe(struct platform_device *pdev)
        struct device *dev = &pdev->dev;
        struct rcar_gen2_phy_driver *drv;
        struct phy_provider *provider;
-       struct device_node *np;
        void __iomem *base;
        struct clk *clk;
        const struct rcar_gen2_phy_data *data;
@@ -379,7 +378,7 @@ static int rcar_gen2_phy_probe(struct platform_device *pdev)
        if (!drv->channels)
                return -ENOMEM;
 
-       for_each_child_of_node(dev->of_node, np) {
+       for_each_child_of_node_scoped(dev->of_node, np) {
                struct rcar_gen2_channel *channel = drv->channels + i;
                u32 channel_num;
                int error, n;
@@ -391,7 +390,6 @@ static int rcar_gen2_phy_probe(struct platform_device *pdev)
                error = of_property_read_u32(np, "reg", &channel_num);
                if (error || channel_num >= data->num_channels) {
                        dev_err(dev, "Invalid \"reg\" property\n");
-                       of_node_put(np);
                        return error;
                }
                channel->select_mask = select_mask[channel_num];