]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
staging: rtl8723bs: fall back to random mac address
authorMichael Straube <straube.linux@gmail.com>
Sat, 4 Oct 2025 10:10:36 +0000 (12:10 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 13 Oct 2025 08:38:37 +0000 (10:38 +0200)
Use a random mac address if we cannot load it from the efuses.

Do not use a constant mac address as fallback. This may create conflicts
if we have several rtl8723bs devices on the network.

Signed-off-by: Michael Straube <straube.linux@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8723bs/hal/sdio_halinit.c

index 6f1f726d1630a1a39b8616c54972ef36724b2e56..4e81ef53dc47dadb681b80612cbc909cf9bfc7a9 100644 (file)
@@ -1014,14 +1014,10 @@ static void Hal_EfuseParseMACAddr_8723BS(
        struct adapter *padapter, u8 *hwinfo, bool AutoLoadFail
 )
 {
-       u16 i;
-       u8 sMacAddr[6] = {0x00, 0xE0, 0x4C, 0xb7, 0x23, 0x00};
        struct eeprom_priv *pEEPROM = GET_EEPROM_EFUSE_PRIV(padapter);
 
        if (AutoLoadFail) {
-/*             sMacAddr[5] = (u8)GetRandomNumber(1, 254); */
-               for (i = 0; i < 6; i++)
-                       pEEPROM->mac_addr[i] = sMacAddr[i];
+               eth_random_addr(pEEPROM->mac_addr);
        } else {
                /* Read Permanent MAC address */
                memcpy(pEEPROM->mac_addr, &hwinfo[EEPROM_MAC_ADDR_8723BS], ETH_ALEN);