Re-fix for bug 28458: AddFDef always replaces the fielddefs every time you run checks...

Patch by Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com

diff --git a/checksetup.pl b/checksetup.pl
index b349a306520afbbee1b901df94ba75524fad4213..561d6fd4cd2adc7ab2d06e180e544f2f3380f76a 100755 (executable)
--- a/checksetup.pl
+++ b/checksetup.pl
@@ -1097,7 +1097,7 @@ AddFDef("component", "Component", 1);
 AddFDef("assigned_to", "AssignedTo", 1);
 AddFDef("reporter", "ReportedBy", 1);
 AddFDef("votes", "Votes", 0);
-AddFDef("qa_contact", "QAContact", 0);
+AddFDef("qa_contact", "QAContact", 1);
 AddFDef("cc", "CC", 1);
 AddFDef("dependson", "BugsThisDependsOn", 0);
 AddFDef("blocked", "OtherBugsDependingOnThis", 0);

diff --git a/doeditparams.cgi b/doeditparams.cgi
index 3d95637fe1b5c1b7e754896183042d9c4ae52ff2..06019b8171c85e928a6a98db39fc4cf23f0c5fe5 100755 (executable)
--- a/doeditparams.cgi
+++ b/doeditparams.cgi
@@ -68,12 +68,6 @@ foreach my $i (@::param_list) {
 #      print "Old: '" . url_quote(Param($i)) . "'<BR>\n";
 #      print "New: '" . url_quote($::FORM{$i}) . "'<BR>\n";
         $::param{$i} = $::FORM{$i};
-        # If the useqacontact Param is changing, update the mailheader
-        if ($i eq 'useqacontact') {
-            print "&nbsp;&nbsp;&nbsp;- Updating mailhead information<br>\n";
-            SendSQL("UPDATE fielddefs SET mailhead = " . SqlQuote($::param{$i}) .
-                    "WHERE name = 'qa_contact'");
-        }
     }
 }