Bug 349015: importxml.pl throws a warning if there is no bug status defined

r/a=LpSolit

diff --git a/importxml.pl b/importxml.pl
index f7ce6e66e0212cfb05f88a69c89f34324082c0b5..9c334efa09efedad8c0306f2f37645d98525b67b 100755 (executable)
--- a/importxml.pl
+++ b/importxml.pl
@@ -841,7 +841,6 @@ sub process_bug {
     my $valid_status = check_field('bug_status',  
                                   scalar $bug_fields{'bug_status'}, 
                                   undef, ERR_LEVEL );
-    my $is_open = is_open_state($bug_fields{'bug_status'}); 
     my $status = $bug_fields{'bug_status'} || undef;
     my $resolution = $bug_fields{'resolution'} || undef;
     
@@ -891,7 +890,7 @@ sub process_bug {
 
     if ($status) {
         if($valid_status){
-            if($is_open){
+            if (is_open_state($status)) {
                 if ($resolution) {
                     $err .= "Resolution set on an open status.\n";
                     $err .= "   Dropping resolution $resolution\n";
@@ -925,7 +924,7 @@ sub process_bug {
                     }
                 }
             }
-            else{ # $is_open is false
+            else {
                if (!$resolution) {
                    $err .= "Missing Resolution. Setting status to ";
                    if($everconfirmed){