Improve documentation by making all of the colors used readable,

no matter what the background color is.

Dark blue on a black background is unreadable, as is yellow on a
light background.  This patch turns on the bright attribute for
colors when on a dark background and turns *off* the bright
attribute when the -W command line option is used (indicating a
_light_ background).  This ensures that text is readable in both
cases.

Patch by: tilghman
Review: https://reviewboard.asterisk.org/r/2224
........

Merged revisions 377509 from http://svn.asterisk.org/svn/asterisk/branches/1.8

git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/10@377510 65c4cc65-6c06-0410-ace0-fbb531ad65f3

diff --git a/main/xmldoc.c b/main/xmldoc.c
index 125cd240b9ef7966eddbc75d685cc31508ae68c4..7e8eca4974384d7b9debcdce16c099c449541893 100644 (file)
--- a/main/xmldoc.c
+++ b/main/xmldoc.c
@@ -354,7 +354,13 @@ char *ast_xmldoc_printable(const char *bwinput, int withcolors)
 
                        /* Setup color */
                        if (withcolors) {
-                               ast_term_color_code(&colorized, colorized_tags[c].colorfg, 0);
+                               if (ast_opt_light_background) {
+                                       /* Turn off *bright* colors */
+                                       ast_term_color_code(&colorized, colorized_tags[c].colorfg & 0x7f, 0);
+                               } else {
+                                       /* Turn on *bright* colors */
+                                       ast_term_color_code(&colorized, colorized_tags[c].colorfg | 0x80, 0);
+                               }
                                if (!colorized) {
                                        return NULL;
                                }