]> git.ipfire.org Git - thirdparty/iproute2.git/commitdiff
nstat: convert sprintf to snprintf
authorDenis Kirjanov <kirjanov@gmail.com>
Wed, 28 Feb 2024 13:58:58 +0000 (08:58 -0500)
committerDavid Ahern <dsahern@kernel.org>
Sun, 3 Mar 2024 22:32:50 +0000 (22:32 +0000)
Use snprintf to print only valid data.
That's the similar change done for ifstat.

Signed-off-by: Denis Kirjanov <dkirjanov@suse.de>
Signed-off-by: David Ahern <dsahern@kernel.org>
misc/nstat.c

index ea96ccb03a2ea534ccaeda952e7c3619c59305a9..7beb620b2f61208b42c5c066ea29b471505fcd4d 100644 (file)
@@ -483,7 +483,7 @@ static void server_loop(int fd)
        p.fd = fd;
        p.events = p.revents = POLLIN;
 
-       sprintf(info_source, "%d.%lu sampling_interval=%d time_const=%d",
+       snprintf(info_source, sizeof(info_source), "%d.%lu sampling_interval=%d time_const=%d",
                getpid(), (unsigned long)random(), scan_interval/1000, time_constant/1000);
 
        load_netstat();
@@ -636,7 +636,7 @@ int main(int argc, char *argv[])
 
        sun.sun_family = AF_UNIX;
        sun.sun_path[0] = 0;
-       sprintf(sun.sun_path+1, "nstat%d", getuid());
+       snprintf(sun.sun_path + 1, sizeof(sun.sun_path) - 1, "nstat%d", getuid());
 
        if (scan_interval > 0) {
                if (time_constant == 0)