Pull side effects out of TEST_CHECK() (CID #1538288)

diff --git a/src/lib/util/edit_tests.c b/src/lib/util/edit_tests.c
index 29bfc58d7d9b70b18a84b58f38a82ad2c2359438..d98a3c26011b764731f84b1e93b1e37e86e5a93d 100644 (file)
--- a/src/lib/util/edit_tests.c
+++ b/src/lib/util/edit_tests.c
@@ -86,15 +86,18 @@ static void add_pairs(fr_pair_list_t *local_pairs)
 
        fr_pair_list_init(local_pairs);
 
-       TEST_CHECK((vp = fr_pair_afrom_da(autofree, fr_dict_attr_test_uint32)) != NULL);
+       vp = fr_pair_afrom_da(autofree, fr_dict_attr_test_uint32);
+       TEST_CHECK(vp != NULL);
        TEST_ASSERT(vp != NULL);
        fr_pair_append(local_pairs, vp);
 
-       TEST_CHECK((vp = fr_pair_afrom_da(autofree, fr_dict_attr_test_octets)) != NULL);
+       vp = fr_pair_afrom_da(autofree, fr_dict_attr_test_octets);
+       TEST_CHECK(vp != NULL);
        TEST_ASSERT(vp != NULL);
        fr_pair_append(local_pairs, vp);
 
-       TEST_CHECK((vp = fr_pair_afrom_da(autofree, fr_dict_attr_test_tlv)) != NULL);
+       vp = fr_pair_afrom_da(autofree, fr_dict_attr_test_tlv);
+       TEST_CHECK(vp != NULL);
        TEST_ASSERT(vp != NULL);
        fr_pair_append(local_pairs, vp);