Don't set load-balancing socket option on the UDP connect sockets

The isc_nm_udpconnect() erroneously set the reuse port with
load-balancing on the outgoing connected UDP sockets.  This socket
option makes only sense for the listening sockets.  Don't set the
load-balancing reuse port option on the outgoing UDP sockets.

diff --git a/lib/isc/netmgr/udp.c b/lib/isc/netmgr/udp.c
index cd5513fc5865bb301aa7ffffad0075c58bacdad9..cda3d9d98cab01a6e2add5db6f3d67a538941263 100644 (file)
--- a/lib/isc/netmgr/udp.c
+++ b/lib/isc/netmgr/udp.c
@@ -846,10 +846,6 @@ isc_nm_udpconnect(isc_nm_t *mgr, isc_sockaddr_t *local, isc_sockaddr_t *peer,
        RUNTIME_CHECK(result == ISC_R_SUCCESS ||
                      result == ISC_R_NOTIMPLEMENTED);
 
-       result = isc__nm_socket_reuse_lb(sock->fd);
-       RUNTIME_CHECK(result == ISC_R_SUCCESS ||
-                     result == ISC_R_NOTIMPLEMENTED);
-
        (void)isc__nm_socket_incoming_cpu(sock->fd);
 
        (void)isc__nm_socket_disable_pmtud(sock->fd, sa_family);