Deal with unchecked return value Coverity reports (#4532)

This deals with the following CIDs: 1503943, 1503949,
1455233, 1503981

diff --git a/src/lib/eap_aka_sim/state_machine.c b/src/lib/eap_aka_sim/state_machine.c
index a3906e44138c05f276da5777663d5b6ca7905434..9bbcea4f3e910a02c1ff8315bf4fb7795a045391 100644 (file)
--- a/src/lib/eap_aka_sim/state_machine.c
+++ b/src/lib/eap_aka_sim/state_machine.c
@@ -722,7 +722,7 @@ RESUME(store_pseudonym)
 
                        fr_value_box_bstrdup_buffer_shallow(NULL, &vp->data, NULL, identity, false);
                }
-               pair_update_request(&new, attr_session_id);
+               MEM(pair_update_request(&new, attr_session_id) >= 0);
                fr_pair_value_memdup(new, (uint8_t const *)vp->vp_strvalue, vp->vp_length, vp->vp_tainted);
 
                MEM(eap_aka_sim_session->fastauth_sent = talloc_bstrndup(eap_aka_sim_session,
@@ -852,7 +852,7 @@ static unlang_action_t session_and_pseudonym_store(rlm_rcode_t *p_result, module
                        identity[talloc_array_length(identity) - 1] = '\0';
                        fr_value_box_bstrdup_buffer_shallow(NULL, &vp->data, NULL, identity, false);
                }
-               pair_update_request(&new, attr_eap_aka_sim_next_pseudonym);
+               MEM(pair_update_request(&new, attr_eap_aka_sim_next_pseudonym) >= 0);
                fr_pair_value_copy(new, vp);
 
                MEM(eap_aka_sim_session->pseudonym_sent = talloc_bstrndup(eap_aka_sim_session,

diff --git a/src/lib/server/main_config.c b/src/lib/server/main_config.c
index da5f81fde197d11bc54395abb94ca5c1d5c33473..495edd1588bc403a0d51d7052faa93406cece353 100644 (file)
--- a/src/lib/server/main_config.c
+++ b/src/lib/server/main_config.c
@@ -486,7 +486,7 @@ static int xlat_config_escape(UNUSED request_t *request, fr_value_box_t *vb, UNU
         */
        if (outlen > vb->vb_length) {
                char    *outbuff;
-               fr_value_box_bstr_realloc(vb, &outbuff, vb, outlen);
+               if (fr_value_box_bstr_realloc(vb, &outbuff, vb, outlen) < 0) return -1;
                memcpy(outbuff, escaped, outlen);
        }
 

diff --git a/src/lib/unlang/subrequest.c b/src/lib/unlang/subrequest.c
index 87c42131697abd11fbdc0c6135a606e6b1062b65..bf0db7799f107a2cde44ffd149e4e7caf8d0a5a7 100644 (file)
--- a/src/lib/unlang/subrequest.c
+++ b/src/lib/unlang/subrequest.c
@@ -109,7 +109,7 @@ static unlang_action_t unlang_subrequest_parent_resume(rlm_rcode_t *p_result, re
                        return UNLANG_ACTION_CALCULATE_RESULT;
                }
                while ((extent = fr_dlist_tail(&leaf))) {
-                       fr_pair_list_copy(extent->list_ctx, extent->list, &child->reply_pairs);
+                       MEM(fr_pair_list_copy(extent->list_ctx, extent->list, &child->reply_pairs) >= 0);
                        fr_dlist_talloc_free_tail(&leaf);
                }
        }