]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
printing: Fix coverity issue CID#1669074 (Unchecked return value)
authorVinit Agnihotri <vagnihot@redhat.com>
Fri, 14 Nov 2025 06:00:20 +0000 (11:30 +0530)
committerAnoop C S <anoopcs@samba.org>
Mon, 17 Nov 2025 08:31:24 +0000 (08:31 +0000)
A new coverity issue (Unchecked return value) is flagged as a regression
due to commit#e9a7dce599e.
This could have been present prior to comit#e9a7dce599e, however got missed.

This change fixes this issue by checking return value.

Signed-off-by: Vinit Agnihotri <vagnihot@redhat.com>
Reviewed-by: Anoop C S <anoopcs@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Anoop C S <anoopcs@samba.org>
Autobuild-Date(master): Mon Nov 17 08:31:24 UTC 2025 on atb-devel-224

source3/printing/printing.c

index 5fe9fcfcd5e66c17fc2eaf2674ab97498f2547ad..a9e8422efab0e0bc08c7f36a10800d1b371b316e 100644 (file)
@@ -1051,12 +1051,18 @@ static int traverse_fn_delete(TDB_CONTEXT *t, TDB_DATA key, TDB_DATA data, void
 
 static void print_cache_flush(const char *sharename)
 {
+       int rc = 0;
        struct tdb_print_db *pdb = get_print_db_byname(sharename);
 
        if (!pdb)
                return;
 
-       update_share_cache_time(CACHE_LAST_SCAN_TIME, sharename, pdb->tdb, -1);
+       rc = update_share_cache_time(CACHE_LAST_SCAN_TIME,
+                                   sharename, pdb->tdb, -1);
+       if (rc != 0) {
+               DBG_ERR("Unable to reset last scan time for share:%s. rc=%d\n",
+                       sharename, rc);
+       }
        release_print_db(pdb);
 }