Bug 282790: Warn if name for a stored query exceeds maximum length

patch by LpSolit
r=mkanat,a=justdave

diff --git a/buglist.cgi b/buglist.cgi
index 4b9bc960f163e27b819d609a551a7ecf6eb02ace..fd01f10d5fa7c5efb0a432b8a7fbc55fe818cee1 100755 (executable)
--- a/buglist.cgi
+++ b/buglist.cgi
@@ -239,6 +239,7 @@ sub InsertNamedQuery ($$$;$) {
     # Validate the query name.
     $query_name || ThrowUserError("query_name_missing");
     $query_name !~ /[<>&]/ || ThrowUserError("illegal_query_name");
+    (length($query_name) <= 64) || ThrowUserError("query_name_too_long");
     trick_taint($query_name);
 
     detaint_natural($userid);

diff --git a/template/en/default/global/user-error.html.tmpl b/template/en/default/global/user-error.html.tmpl
index ac2cba6d3c9280b1cdd92e5d8317383ac26b979b..55c7969242ed8255aaecb6b5563ce0c1b3756b7d 100644 (file)
--- a/template/en/default/global/user-error.html.tmpl
+++ b/template/en/default/global/user-error.html.tmpl
@@ -862,6 +862,10 @@
     [% title = "No Search Name Specified" %]
     You must enter a name for your search.
 
+  [% ELSIF error == "query_name_too_long" %]
+    [% title = "Query Name Too Long" %]
+    The name of the query must be less than 64 characters long.
+
   [% ELSIF error == "quips_disabled" %]
     [% title = "Quips Disabled" %]
     Quips are disabled.