]> git.ipfire.org Git - thirdparty/kea.git/commitdiff
[#101,!87] Disable config-control in kea-dhcp4 until CB work resumes 101-cb-add-two-step-configuration-to-the-dhcpv4-server-3
authorThomas Markwalder <tmark@isc.org>
Fri, 19 Oct 2018 13:12:25 +0000 (09:12 -0400)
committerThomas Markwalder <tmark@isc.org>
Fri, 19 Oct 2018 13:12:25 +0000 (09:12 -0400)
src/bin/dhcp4/json_config_parser.cc
src/bin/dhcp4/tests/config_parser_unittest.cc

index 654a0c4f68b4e5a1e755621ecd652fa547b1c6a1..2b8ad3cdbfff9e207368f2570e4fe02b3d6a26b3 100644 (file)
@@ -596,8 +596,10 @@ configureDhcp4Server(Dhcpv4Srv& server, isc::data::ConstElementPtr config_set,
                 CfgMgr::instance().getStagingCfg()->getHooksConfig();
             libraries.loadLibraries();
 
+#ifdef CONFIG_BACKEND // Disabled until we restart CB work
             // If there are config backends, fetch and merge into staging config
             databaseConfigFetch(srv_cfg, mutable_cfg);
+#endif
         }
         catch (const isc::Exception& ex) {
             LOG_ERROR(dhcp4_logger, DHCP4_PARSER_COMMIT_FAIL).arg(ex.what());
index 4168b309d4613ec74f016dcc598103c204fa168e..fbb8599e21c2f1da9ddbad59e45cdad51bb83253 100644 (file)
@@ -6259,6 +6259,9 @@ TEST_F(Dhcp4ParserTest, globalReservations) {
     EXPECT_FALSE(hosts_cfg->get4(542, Host::IDENT_DUID, &duid[0], duid.size()));
 }
 
+// Rather than disable these tests they are compiled out.  This avoids them
+// reporting as disbabled and thereby drawing attention to them.
+#ifdef CONFIG_BACKEND
 // This test verifies that configuration control with unsupported type fails
 TEST_F(Dhcp4ParserTest, configControlInfoNoFactory) {
     string config = PARSER_CONFIGS[6];
@@ -6336,5 +6339,6 @@ TEST_F(Dhcp4ParserTest, serverTag) {
     // Make sure a invalid server-tag fails to parse.
     ASSERT_THROW(parseDHCP4(bad_tag), std::exception);
 }
+#endif // CONFIG_BACKEND
 
 }