Bug 380928 â\80\93 Bugzilla::Auth::Verify::create_or_update_user can return stale Bugzill...

patch by vrb@novell.com r=mkanat a=mkanat

diff --git a/.project b/.project
new file mode 100644 (file)
index 0000000..57f163c
--- /dev/null
+++ b/.project
@@ -0,0 +1,17 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<projectDescription>
+       <name>bmo-tip</name>
+       <comment></comment>
+       <projects>
+       </projects>
+       <buildSpec>
+               <buildCommand>
+                       <name>org.epic.perleditor.perlbuilder</name>
+                       <arguments>
+                       </arguments>
+               </buildCommand>
+       </buildSpec>
+       <natures>
+               <nature>org.epic.perleditor.perlnature</nature>
+       </natures>
+</projectDescription>

diff --git a/Bugzilla/Auth/Verify.pm b/Bugzilla/Auth/Verify.pm
index deb5f4e951c6db3ea0134995ee99c49ba7924b0c..b293e2583dfc3ecb6aa114f512e3150229d34f0c 100644 (file)
--- a/Bugzilla/Auth/Verify.pm
+++ b/Bugzilla/Auth/Verify.pm
@@ -116,16 +116,15 @@ sub create_or_update_user {
         validate_email_syntax($username)
           || return { failure => AUTH_ERROR, error => 'auth_invalid_email',
                       details => {addr => $username} };
-        $dbh->do('UPDATE profiles SET login_name = ? WHERE userid = ?',
-                 undef, $username, $user->id);
+        $user->set_login($username);
     }
     if ($real_name && $user->name ne $real_name) {
         # $real_name is more than likely tainted, but we only use it
         # in a placeholder and we never use it after this.
         trick_taint($real_name);
-        $dbh->do('UPDATE profiles SET realname = ? WHERE userid = ?',
-                 undef, $real_name, $user->id);
+        $user->set_name($real_name);
     }
+    $user->update();
 
     return { user => $user };
 }