]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
python:tests/krb5: let set_pac_sids() replace the requester_sid
authorStefan Metzmacher <metze@samba.org>
Tue, 3 Dec 2024 11:50:18 +0000 (12:50 +0100)
committerRalph Boehme <slow@samba.org>
Mon, 24 Feb 2025 09:27:38 +0000 (09:27 +0000)
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
python/samba/tests/krb5/kdc_base_test.py

index 36a7300a76e2b699efbe9e1ed164ed904146ed2b..8caa635c9adc4e106ac52cc4d91253d7d280a0fb 100644 (file)
@@ -1906,6 +1906,7 @@ class KDCBaseTest(TestCaseInTempDir, RawKerberosTest):
                      new_sids,
                      domain_sid=None,
                      user_rid=None,
+                     requester_sid=None,
                      set_user_flags=0,
                      reset_user_flags=0):
         if domain_sid is None:
@@ -2033,8 +2034,9 @@ class KDCBaseTest(TestCaseInTempDir, RawKerberosTest):
                     upn_dns_info_ex.objectsid = security.dom_sid(
                         f'{domain_sid}-{user_rid}')
 
-            # But don't replace the user's SID in the Requester SID buffer, or
-            # we'll get a SID mismatch.
+            elif pac_buffer.type == krb5pac.PAC_TYPE_REQUESTER_SID:
+                if requester_sid is not None:
+                    pac_buffer.info.sid = requester_sid
 
         self.assertTrue(found_logon_info, 'no LOGON_INFO PAC buffer')