]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
phy: phy-snps-eusb2: clean up error messages
authorJohan Hovold <johan+linaro@kernel.org>
Fri, 23 May 2025 08:48:36 +0000 (10:48 +0200)
committerVinod Koul <vkoul@kernel.org>
Sun, 15 Jun 2025 16:32:41 +0000 (22:02 +0530)
Clean up the error messages by using a consistent format with a colon
followed by a space and an errno (or unsupported frequency).

Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Reviewed-by: Abel Vesa <abel.vesa@linaro.org>
Link: https://lore.kernel.org/r/20250523084839.11015-5-johan+linaro@kernel.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/phy-snps-eusb2.c

index c8f14f8fb9acb816ba399f0bc08ccf0cd178e88d..232c5e8a554f8c81237f31db27952e486e653b02 100644 (file)
@@ -256,7 +256,7 @@ static int exynos_eusb2_ref_clk_init(struct snps_eusb2_hsphy *phy)
        }
 
        if (!config) {
-               dev_err(&phy->phy->dev, "unsupported ref_clk_freq:%lu\n", ref_clk_freq);
+               dev_err(&phy->phy->dev, "unsupported ref_clk_freq: %lu\n", ref_clk_freq);
                return -EINVAL;
        }
 
@@ -293,7 +293,7 @@ static int qcom_eusb2_ref_clk_init(struct snps_eusb2_hsphy *phy)
        }
 
        if (!config) {
-               dev_err(&phy->phy->dev, "unsupported ref_clk_freq:%lu\n", ref_clk_freq);
+               dev_err(&phy->phy->dev, "unsupported ref_clk_freq: %lu\n", ref_clk_freq);
                return -EINVAL;
        }
 
@@ -461,19 +461,19 @@ static int snps_eusb2_hsphy_init(struct phy *p)
 
        ret = phy_init(phy->repeater);
        if (ret) {
-               dev_err(&p->dev, "repeater init failed. %d\n", ret);
+               dev_err(&p->dev, "repeater init failed: %d\n", ret);
                goto disable_vreg;
        }
 
        ret = clk_bulk_prepare_enable(phy->data->num_clks, phy->clks);
        if (ret) {
-               dev_err(&p->dev, "failed to enable ref clock, %d\n", ret);
+               dev_err(&p->dev, "failed to enable ref clock: %d\n", ret);
                goto exit_repeater;
        }
 
        ret = reset_control_assert(phy->phy_reset);
        if (ret) {
-               dev_err(&p->dev, "failed to assert phy_reset, %d\n", ret);
+               dev_err(&p->dev, "failed to assert phy_reset: %d\n", ret);
                goto disable_clks;
        }
 
@@ -481,7 +481,7 @@ static int snps_eusb2_hsphy_init(struct phy *p)
 
        ret = reset_control_deassert(phy->phy_reset);
        if (ret) {
-               dev_err(&p->dev, "failed to de-assert phy_reset, %d\n", ret);
+               dev_err(&p->dev, "failed to de-assert phy_reset: %d\n", ret);
                goto disable_clks;
        }
 
@@ -588,7 +588,7 @@ static int snps_eusb2_hsphy_probe(struct platform_device *pdev)
 
        generic_phy = devm_phy_create(dev, NULL, &snps_eusb2_hsphy_ops);
        if (IS_ERR(generic_phy)) {
-               dev_err(dev, "failed to create phy %d\n", ret);
+               dev_err(dev, "failed to create phy: %d\n", ret);
                return PTR_ERR(generic_phy);
        }