]> git.ipfire.org Git - thirdparty/pdns.git/commitdiff
dnsdist: Fix off-by-one in the TCP connection rate regression test
authorRemi Gacogne <remi.gacogne@powerdns.com>
Thu, 7 May 2026 16:01:22 +0000 (18:01 +0200)
committerRemi Gacogne <remi.gacogne@powerdns.com>
Mon, 11 May 2026 09:22:07 +0000 (11:22 +0200)
Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
regression-tests.dnsdist/test_TCPLimits.py

index d304ef6383a3ce339eb43b6be668d165d9e3706a..35bbe81cd1a85167afe68923da156f2132bc20cb 100644 (file)
@@ -234,8 +234,8 @@ class TestTCPLimitsConnectionRate(DNSDistTest):
         query = dns.message.make_query(name, "A", "IN")
         response = dns.message.make_response(query)
 
-        # _maxConnectionRate connections in a row
-        for idx in range(self._maxConnectionRate):
+        # _maxConnectionRate connections in a row (minus one because startResponders opens a TCP connection to see if dnsdist is running)
+        for idx in range(self._maxConnectionRate - 1):
             (receivedQuery, receivedResponse) = self.sendTCPQuery(query, response=response)
             receivedQuery.id = query.id
             self.assertEqual(receivedQuery, query)