]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu: remove possible garbage left from previous rename/undefine
authorNikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
Tue, 3 Nov 2020 07:16:21 +0000 (10:16 +0300)
committerNikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
Fri, 13 Nov 2020 11:49:50 +0000 (14:49 +0300)
Due to failures to unlink on previous rename/undefine we can already have
autolink etc files for the domain to be defined. Remove them.

Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
src/qemu/qemu_driver.c
src/qemu/qemu_migration.c

index cb7da97b8ed53487028c799d371f964b9c6492d5..8e20a931a2accba34591d2513af3064fe25494d9 100644 (file)
@@ -6719,6 +6719,9 @@ qemuDomainDefineXMLFlags(virConnectPtr conn,
         goto cleanup;
     def = NULL;
 
+    if (!oldDef && qemuDomainNamePathsCleanup(cfg, vm->def->name, false) < 0)
+        goto cleanup;
+
     if (virDomainDefSave(vm->newDef ? vm->newDef : vm->def,
                          driver->xmlopt, cfg->configDir) < 0)
         goto cleanup;
@@ -19179,6 +19182,9 @@ qemuDomainRenameCallback(virDomainObjPtr vm,
                                                  vm->def->name)))
         return -1;
 
+    if (qemuDomainNamePathsCleanup(cfg, new_name, false) < 0)
+        goto cleanup;
+
     if (vm->autostart) {
         if (!(new_dom_autostart_link = virDomainConfigFile(cfg->autostartDir,
                                                           new_dom_name)) ||
index 8c3af7f04a8234368b4d75cd9844915c9406b0b5..fef0be63a1a76d7b32271eaaf40fc276f282f57c 100644 (file)
@@ -5137,6 +5137,9 @@ qemuMigrationDstPersist(virQEMUDriverPtr driver,
                                                priv->qemuCaps)))
         goto error;
 
+    if (!oldPersist && qemuDomainNamePathsCleanup(cfg, vmdef->name, false) < 0)
+        goto error;
+
     if (virDomainDefSave(vmdef, driver->xmlopt, cfg->configDir) < 0 &&
         !ignoreSaveError)
         goto error;