]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s3: VFS: streams_xattr: In streams_xattr_pwrite() - remove smb_fname_base.
authorJeremy Allison <jra@samba.org>
Wed, 23 Jun 2021 00:16:09 +0000 (17:16 -0700)
committerRalph Boehme <slow@samba.org>
Fri, 25 Jun 2021 15:53:31 +0000 (15:53 +0000)
No longer used and we were leaking it onto the talloc_tos() anyway.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
source3/modules/vfs_streams_xattr.c

index b525ac973f9930a157a8d7996d636dc17e6934fa..4fcfeba30606e3ae9e17b411ff111fb921ec4ee4 100644 (file)
@@ -962,7 +962,6 @@ static ssize_t streams_xattr_pwrite(vfs_handle_struct *handle,
                (struct stream_io *)VFS_FETCH_FSP_EXTENSION(handle, fsp);
        struct ea_struct ea;
        NTSTATUS status;
-       struct smb_filename *smb_fname_base = NULL;
        int ret;
 
        DEBUG(10, ("streams_xattr_pwrite called for %d bytes\n", (int)n));
@@ -996,18 +995,6 @@ static ssize_t streams_xattr_pwrite(vfs_handle_struct *handle,
                return -1;
        }
 
-       /* Create an smb_filename with stream_name == NULL. */
-       smb_fname_base = synthetic_smb_fname(talloc_tos(),
-                                       sio->base,
-                                       NULL,
-                                       NULL,
-                                       fsp->fsp_name->twrp,
-                                       fsp->fsp_name->flags);
-       if (smb_fname_base == NULL) {
-               errno = ENOMEM;
-               return -1;
-       }
-
        status = get_ea_value(talloc_tos(),
                              handle->conn,
                              fsp->base_fsp,