]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
nwfilter: move standard XML configs out of examples dir
authorDaniel P. Berrangé <berrange@redhat.com>
Fri, 19 Jul 2019 17:31:20 +0000 (18:31 +0100)
committerDaniel P. Berrangé <berrange@redhat.com>
Mon, 19 Aug 2019 10:52:44 +0000 (11:52 +0100)
The nwfilter XML configs are not merely examples, they are data that is
actively shipped and used in production by users.

Reviewed-by: Erik Skultety <eskultet@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
21 files changed:
examples/Makefile.am
src/nwfilter/Makefile.inc.am
src/nwfilter/xml/allow-arp.xml [moved from examples/xml/nwfilter/allow-arp.xml with 100% similarity]
src/nwfilter/xml/allow-dhcp-server.xml [moved from examples/xml/nwfilter/allow-dhcp-server.xml with 100% similarity]
src/nwfilter/xml/allow-dhcp.xml [moved from examples/xml/nwfilter/allow-dhcp.xml with 100% similarity]
src/nwfilter/xml/allow-incoming-ipv4.xml [moved from examples/xml/nwfilter/allow-incoming-ipv4.xml with 100% similarity]
src/nwfilter/xml/allow-ipv4.xml [moved from examples/xml/nwfilter/allow-ipv4.xml with 100% similarity]
src/nwfilter/xml/clean-traffic-gateway.xml [moved from examples/xml/nwfilter/clean-traffic-gateway.xml with 100% similarity]
src/nwfilter/xml/clean-traffic.xml [moved from examples/xml/nwfilter/clean-traffic.xml with 100% similarity]
src/nwfilter/xml/no-arp-ip-spoofing.xml [moved from examples/xml/nwfilter/no-arp-ip-spoofing.xml with 100% similarity]
src/nwfilter/xml/no-arp-mac-spoofing.xml [moved from examples/xml/nwfilter/no-arp-mac-spoofing.xml with 100% similarity]
src/nwfilter/xml/no-arp-spoofing.xml [moved from examples/xml/nwfilter/no-arp-spoofing.xml with 100% similarity]
src/nwfilter/xml/no-ip-multicast.xml [moved from examples/xml/nwfilter/no-ip-multicast.xml with 100% similarity]
src/nwfilter/xml/no-ip-spoofing.xml [moved from examples/xml/nwfilter/no-ip-spoofing.xml with 100% similarity]
src/nwfilter/xml/no-mac-broadcast.xml [moved from examples/xml/nwfilter/no-mac-broadcast.xml with 100% similarity]
src/nwfilter/xml/no-mac-spoofing.xml [moved from examples/xml/nwfilter/no-mac-spoofing.xml with 100% similarity]
src/nwfilter/xml/no-other-l2-traffic.xml [moved from examples/xml/nwfilter/no-other-l2-traffic.xml with 100% similarity]
src/nwfilter/xml/no-other-rarp-traffic.xml [moved from examples/xml/nwfilter/no-other-rarp-traffic.xml with 100% similarity]
src/nwfilter/xml/qemu-announce-self-rarp.xml [moved from examples/xml/nwfilter/qemu-announce-self-rarp.xml with 100% similarity]
src/nwfilter/xml/qemu-announce-self.xml [moved from examples/xml/nwfilter/qemu-announce-self.xml with 100% similarity]
tests/virschematest.c

index 0adb4b42e2d7c2eeaf638df9f5de57d53e98738b..ad635bdcc05d08209eed8d68aadc808b9f8cd96f 100644 (file)
@@ -16,8 +16,6 @@
 ## License along with this library.  If not, see
 ## <http://www.gnu.org/licenses/>.
 
-FILTERS = $(wildcard $(srcdir)/xml/nwfilter/*.xml)
-
 ADMIN_EXAMPLES = \
        $(wildcard $(srcdir)/c/admin/*.c) \
        $(NULL)
@@ -56,7 +54,6 @@ EXTRA_DIST = \
        $(STORAGE_XML_EXAMPLES) \
        $(SYSTEMTAP_EXAMPLES) \
        $(TEST_XML_EXAMPLES) \
-       $(FILTERS) \
        $(NULL)
 
 AM_CPPFLAGS = \
@@ -111,13 +108,6 @@ c_misc_event_test_SOURCES = c/misc/event-test.c
 c_misc_hellolibvirt_SOURCES = c/misc/hellolibvirt.c
 c_misc_openauth_SOURCES = c/misc/openauth.c
 
-if WITH_NWFILTER
-
-nwfilterdir = $(sysconfdir)/libvirt/nwfilter
-nwfilter_DATA = $(FILTERS)
-
-endif WITH_NWFILTER
-
 examplesdir = $(docdir)/examples
 
 adminexamplesdir = $(examplesdir)/c/admin
index 277f75a9bd473fa52f1bdff1027df46357e61923..7693634e291de4c44ec4b3afec76c430128b0e61 100644 (file)
@@ -1,5 +1,9 @@
 # vim: filetype=automake
 
+NWFILTER_XML_FILES = $(wildcard $(srcdir)/nwfilter/xml/*.xml)
+
+EXTRA_DIST += $(NWFILTER_XML_FILES)
+
 NWFILTER_DRIVER_SOURCES = \
        nwfilter/nwfilter_driver.h \
        nwfilter/nwfilter_driver.c \
@@ -19,6 +23,10 @@ STATEFUL_DRIVER_SOURCE_FILES += $(NWFILTER_DRIVER_SOURCES)
 EXTRA_DIST += $(NWFILTER_DRIVER_SOURCES)
 
 if WITH_NWFILTER
+
+nwfilterxmldir = $(sysconfdir)/libvirt/nwfilter
+nwfilterxml_DATA = $(NWFILTER_XML_FILES)
+
 noinst_LTLIBRARIES += libvirt_driver_nwfilter_impl.la
 libvirt_driver_nwfilter_la_SOURCES =
 libvirt_driver_nwfilter_la_LIBADD = libvirt_driver_nwfilter_impl.la
index d5a56d3f9615d9f0cbf93d512a10c5ee5d20d50b..dabbc02163a909d7d5097a0471ce54bf41f68821 100644 (file)
@@ -231,7 +231,7 @@ mymain(void)
                 "networkxml2xmlout", "networkxml2confdata");
     DO_TEST_DIR("networkport.rng", "virnetworkportxml2xmldata");
     DO_TEST_DIR("nodedev.rng", "nodedevschemadata");
-    DO_TEST_DIR("nwfilter.rng", "nwfilterxml2xmlout", "../examples/xml/nwfilter");
+    DO_TEST_DIR("nwfilter.rng", "nwfilterxml2xmlout", "../src/nwfilter");
     DO_TEST_DIR("nwfilterbinding.rng", "virnwfilterbindingxml2xmldata");
     DO_TEST_DIR("secret.rng", "secretxml2xmlin");
     DO_TEST_DIR("storagepoolcaps.rng", "storagepoolcapsschemadata");