Author: rousskov

Bug 1978: fwdServerClose retries non-idempotent methods

checkRetry is now guaranteed to return false for requests that checkRetriable
previously returned false. This prevents retries of requests with
non-idempotent methods, for example.

diff --git a/src/forward.cc b/src/forward.cc
index d71f2d87ba35c57e12d8b24cfea9f4947046ac5c..9a928776ccf69253bb9ed9ad91153c93b7e0b360 100644 (file)
--- a/src/forward.cc
+++ b/src/forward.cc
@@ -1,6 +1,6 @@
 
 /*
- * $Id: forward.cc,v 1.168.2.1 2008/02/27 10:38:21 amosjeffries Exp $
+ * $Id: forward.cc,v 1.168.2.2 2008/02/27 10:42:23 amosjeffries Exp $
  *
  * DEBUG: section 17    Request Forwarding
  * AUTHOR: Duane Wessels
@@ -442,6 +442,9 @@ FwdState::checkRetry()
     if (flags.dont_retry)
         return false;
 
+    if (!checkRetriable())
+        return false;
+
     if (request->bodyNibbled())
         return false;