MIPS: ip22-gio: fix device reference leak in probe

The gio probe function needlessly takes a device reference which is
never released and therefore prevents unbound gio devices from being
freed.

Fixes: e84de0c61905 ("MIPS: GIO bus support for SGI IP22/28")
Cc: stable@vger.kernel.org	# 3.3
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>

diff --git a/arch/mips/sgi-ip22/ip22-gio.c b/arch/mips/sgi-ip22/ip22-gio.c
index 2f5c6c6f82540612d70ad3032a0c6f0d1cc8019a..7b7572d1125015fe99ebb9531f7003b09d707598 100644 (file)
--- a/arch/mips/sgi-ip22/ip22-gio.c
+++ b/arch/mips/sgi-ip22/ip22-gio.c
@@ -133,13 +133,9 @@ static int gio_device_probe(struct device *dev)
        if (!drv->probe)
                return error;
 
-       gio_dev_get(gio_dev);
-
        match = gio_match_device(drv->id_table, gio_dev);
        if (match)
                error = drv->probe(gio_dev, match);
-       if (error)
-               gio_dev_put(gio_dev);
 
        return error;
 }