]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
RDMA/mlx5: Fix incorrect MKEY masking
authorLeon Romanovsky <leonro@nvidia.com>
Sun, 20 Jul 2025 09:25:35 +0000 (12:25 +0300)
committerLeon Romanovsky <leon@kernel.org>
Mon, 21 Jul 2025 06:27:52 +0000 (02:27 -0400)
mkey_mask is __be64 type, while MLX5_MKEY_MASK_PAGE_SIZE is declared as
unsigned long long. This causes to the static checkers errors:

drivers/infiniband/hw/mlx5/umr.c:663:49: warning: invalid assignment: &=
drivers/infiniband/hw/mlx5/umr.c:663:49:    left side has type restricted __be64
drivers/infiniband/hw/mlx5/umr.c:663:49:    right side has type int

Fixes: e73242aa14d2 ("RDMA/mlx5: Optimize DMABUF mkey page size")
Link: https://patch.msgid.link/e354d70b98dfa5ecf4c236a36cd36b64add9d9de.1753003467.git.leon@kernel.org
Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
drivers/infiniband/hw/mlx5/umr.c

index 054f6dae241513bf9ae0aec63faabcae20519e3e..7ef35cddce81caaeea031ead77a105ff80f26b24 100644 (file)
@@ -660,7 +660,8 @@ static void mlx5r_umr_final_update_xlt(struct mlx5_ib_dev *dev,
                if (!mr->ibmr.length)
                        MLX5_SET(mkc, &wqe->mkey_seg, length64, 1);
                if (flags & MLX5_IB_UPD_XLT_KEEP_PGSZ)
-                       wqe->ctrl_seg.mkey_mask &= ~MLX5_MKEY_MASK_PAGE_SIZE;
+                       wqe->ctrl_seg.mkey_mask &=
+                               cpu_to_be64(~MLX5_MKEY_MASK_PAGE_SIZE);
        }
 
        wqe->ctrl_seg.xlt_octowords =