]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
virrandom: Fix printf format string in virRandomGenerateWWN()
authorMichal Privoznik <mprivozn@redhat.com>
Mon, 17 Jul 2023 13:24:43 +0000 (15:24 +0200)
committerMichal Privoznik <mprivozn@redhat.com>
Wed, 19 Jul 2023 11:09:11 +0000 (13:09 +0200)
Firstly, drop needless concatenation of two static strings.
Secondly, use proper (portable) formatter for uint64_t so that
typecast to ULL can be dropped.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
src/util/virrandom.c

index 73c5832a059c1ac904de57ad29b85b71dd9d7651..58f86d5a00d6c6a7781fde3b78312aa3342f35c1 100644 (file)
@@ -154,8 +154,7 @@ virRandomGenerateWWN(char **wwn,
         return -1;
     }
 
-    *wwn = g_strdup_printf("5" "%s%09llx", oui,
-                           (unsigned long long)virRandomBits(36));
+    *wwn = g_strdup_printf("5%s%09" PRIx64, oui, virRandomBits(36));
     return 0;
 }