]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
s390/cpum_sf: Remove WARN_ON_ONCE statements
authorThomas Richter <tmricht@linux.ibm.com>
Wed, 10 Jul 2024 10:23:47 +0000 (12:23 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 17 Oct 2024 13:11:50 +0000 (15:11 +0200)
[ Upstream commit b495e710157606889f2d8bdc62aebf2aa02f67a7 ]

Remove WARN_ON_ONCE statements. These have not triggered in the
past.

Signed-off-by: Thomas Richter <tmricht@linux.ibm.com>
Acked-by: Sumanth Korikkar <sumanthk@linux.ibm.com>
Cc: Heiko Carstens <hca@linux.ibm.com>
Cc: Vasily Gorbik <gor@linux.ibm.com>
Cc: Alexander Gordeev <agordeev@linux.ibm.com>
Signed-off-by: Vasily Gorbik <gor@linux.ibm.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
arch/s390/kernel/perf_cpum_sf.c

index 4e6fadaeaa1a6fc60da5ef73807b289af75bbc1d..a8ba3887b367fca79614d3e3d183bbcd42275382 100644 (file)
@@ -1432,7 +1432,7 @@ static int aux_output_begin(struct perf_output_handle *handle,
        unsigned long head, base, offset;
        struct hws_trailer_entry *te;
 
-       if (WARN_ON_ONCE(handle->head & ~PAGE_MASK))
+       if (handle->head & ~PAGE_MASK)
                return -EINVAL;
 
        aux->head = handle->head >> PAGE_SHIFT;
@@ -1613,7 +1613,7 @@ static void hw_collect_aux(struct cpu_hw_sf *cpuhw)
        unsigned long num_sdb;
 
        aux = perf_get_aux(handle);
-       if (WARN_ON_ONCE(!aux))
+       if (!aux)
                return;
 
        /* Inform user space new data arrived */
@@ -1635,7 +1635,7 @@ static void hw_collect_aux(struct cpu_hw_sf *cpuhw)
                                            __func__);
                        break;
                }
-               if (WARN_ON_ONCE(!aux))
+               if (!aux)
                        return;
 
                /* Update head and alert_mark to new position */
@@ -1870,12 +1870,8 @@ static void cpumsf_pmu_start(struct perf_event *event, int flags)
 {
        struct cpu_hw_sf *cpuhw = this_cpu_ptr(&cpu_hw_sf);
 
-       if (WARN_ON_ONCE(!(event->hw.state & PERF_HES_STOPPED)))
+       if (!(event->hw.state & PERF_HES_STOPPED))
                return;
-
-       if (flags & PERF_EF_RELOAD)
-               WARN_ON_ONCE(!(event->hw.state & PERF_HES_UPTODATE));
-
        perf_pmu_disable(event->pmu);
        event->hw.state = 0;
        cpuhw->lsctl.cs = 1;