]> git.ipfire.org Git - thirdparty/snort3.git/commitdiff
Pull request #4961: Fix:Coverity issue due to copy instead of move
authorArnab Kumar Singh (arnsingh) <arnsingh@cisco.com>
Mon, 10 Nov 2025 07:08:09 +0000 (07:08 +0000)
committerLokesh Bevinamarad (lbevinam) <lbevinam@cisco.com>
Mon, 10 Nov 2025 07:08:09 +0000 (07:08 +0000)
Merge in SNORT/snort3 from ~ARNSINGH/snort3:copyinsteadmove to master

Squashed commit of the following:

commit c2531f56ac8d343f45b5bd4869dfca2621516f4f
Author: arnsingh <arnsingh@cisco.com>
Date:   Sun Oct 26 14:25:20 2025 +0530

    dce_rpc: changed copy to move

src/service_inspectors/dce_rpc/dce_smb2_utils.h

index 7650a37e12e946ee28fd9bbbc4ba2aa43bbae627..3588a45b3b9e65a2c162af59d57db731601d128f 100644 (file)
@@ -132,7 +132,7 @@ inline void DCE2_Smb2InsertSidInSsd(DCE2_Smb2SsnData* ssd, const uint64_t sid,
     {
         stracker->insertConnectionTracker(ssd->flow_key, ssd);
     }
-    ssd->insert_session_tracker(sid, stracker);
+    ssd->insert_session_tracker(sid, std::move(stracker));
 }
 
 inline void DCE2_Smb2RemoveSidInSsd(DCE2_Smb2SsnData* ssd, const uint64_t sid)