]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu: capabilities: Disable detection of QEMU_CAPS_BLOCK_EXPORT_ADD
authorPeter Krempa <pkrempa@redhat.com>
Mon, 26 Oct 2020 10:26:50 +0000 (11:26 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Thu, 29 Oct 2020 17:08:39 +0000 (18:08 +0100)
We use the capability to switch to using 'block-export-add' in the
upcoming qemu release instead of the at the same time deprecated
'nbd-server-add'.

Unfortunately qemu wants to change the interface of 'block-export-add'
before the release. Since we've tried to stay up to date and added the
code before it was written in stone, we need to disable the use of the
new interface for the upcoming libvirt release so that we don't have a
version of libvirt which would not work with the upcoming qemu version.

Remove the detection of 'block-export-add' until we are more sure how
the qemu interface will look.

This patch partially reverts commit adb9f7123adb94645

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
src/qemu/qemu_capabilities.c
tests/qemucapabilitiesdata/caps_5.2.0.x86_64.xml

index a67fb785b52072efde70b9a29369c9b857255fda..78be372a0c45bbe7853bbd005fa1da5237a7dcdc 100644 (file)
@@ -1172,7 +1172,6 @@ struct virQEMUCapsStringFlags virQEMUCapsCommands[] = {
     { "block-dirty-bitmap-merge", QEMU_CAPS_BITMAP_MERGE },
     { "query-cpu-model-baseline", QEMU_CAPS_QUERY_CPU_MODEL_BASELINE },
     { "query-cpu-model-comparison", QEMU_CAPS_QUERY_CPU_MODEL_COMPARISON },
-    { "block-export-add", QEMU_CAPS_BLOCK_EXPORT_ADD },
 };
 
 struct virQEMUCapsStringFlags virQEMUCapsMigration[] = {
index 7e07ac486d104402d66e1e8dba05f8b620199afc..63e947c1b37bab440ba6ff6d2a80cd50b66d3828 100644 (file)
   <flag name='blockdev-hostdev-scsi'/>
   <flag name='usb-host.hostdevice'/>
   <flag name='virtio-balloon.free-page-reporting'/>
-  <flag name='block-export-add'/>
   <flag name='netdev.vhost-vdpa'/>
   <version>5001050</version>
   <kvmVersion>0</kvmVersion>