]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
spi: spi-fsl-lpspi: convert min_t() to simple min()
authorCarlos Song <carlos.song@nxp.com>
Wed, 10 Dec 2025 10:50:01 +0000 (18:50 +0800)
committerMark Brown <broonie@kernel.org>
Sun, 14 Dec 2025 10:39:29 +0000 (19:39 +0900)
Current min() has supported comparison by normal integer promotion rules,
so explicit type casts or min_t() are not needed.

Signed-off-by: Carlos Song <carlos.song@nxp.com>
Reviewed-by: David Laight <david.laight.linux@gmail.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
Link: https://patch.msgid.link/20251210105001.3891776-1-carlos.song@nxp.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-fsl-lpspi.c

index 065456aba2aea93f24f0df8d3e0327765eced372..8f45ead238366590402abe46f135bc14b966ca28 100644 (file)
@@ -486,15 +486,7 @@ static int fsl_lpspi_setup_transfer(struct spi_controller *controller,
                fsl_lpspi->tx = fsl_lpspi_buf_tx_u32;
        }
 
-       /*
-        * t->len is 'unsigned' and txfifosize and watermrk is 'u8', force
-        * type cast is inevitable. When len > 255, len will be truncated in min_t(),
-        * it caused wrong watermark set. 'unsigned int' is as the designated type
-        * for min_t() to avoid truncation.
-        */
-       fsl_lpspi->watermark = min_t(unsigned int,
-                                    fsl_lpspi->txfifosize,
-                                    t->len);
+       fsl_lpspi->watermark = min(fsl_lpspi->txfifosize, t->len);
 
        if (fsl_lpspi_can_dma(controller, spi, t))
                fsl_lpspi->usedma = true;