Merged revisions 218566 via svnmerge from

https://origsvn.digium.com/svn/asterisk/trunk

........
  r218566 | mmichelson | 2009-09-15 10:40:14 -0500 (Tue, 15 Sep 2009) | 4 lines

  Use a better method of ensuring null-termination of the buffer
  while reading the SDP when using TCP.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@218574 65c4cc65-6c06-0410-ace0-fbb531ad65f3

diff --git a/channels/chan_sip.c b/channels/chan_sip.c
index 5a07d782e0479b531e3a9996973ec13a6466421c..f87fe8af8557789ca52e1c482215a89cec88e01a 100644 (file)
--- a/channels/chan_sip.c
+++ b/channels/chan_sip.c
@@ -2448,12 +2448,13 @@ static void *_sip_tcp_helper_thread(struct sip_pvt *pvt, struct ast_tcptls_sessi
                parse_request(&reqcpy);
                if (sscanf(get_header(&reqcpy, "Content-Length"), "%30d", &cl)) {
                        while (cl > 0) {
+                               size_t bytes_read;
                                ast_mutex_lock(&tcptls_session->lock);
-                               if (!fread(buf, MIN(sizeof(buf) - 1, cl), 1, tcptls_session->f)) {
+                               if (!(bytes_read = fread(buf, MIN(sizeof(buf) - 1, cl), 1, tcptls_session->f))) {
                                        ast_mutex_unlock(&tcptls_session->lock);
                                        goto cleanup;
                                }
-                               buf[sizeof(buf)-1] = '\0';
+                               buf[bytes_read] = '\0';
                                ast_mutex_unlock(&tcptls_session->lock);
                                if (me->stop)
                                        goto cleanup;