]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ARM: dts: aspeed: clemente: move hdd_led to its own gpio-leds group
authorAlex Wang <alex.ts.wang@fii-foxconn.com>
Thu, 27 Nov 2025 09:44:51 +0000 (17:44 +0800)
committerAndrew Jeffery <andrew@codeconstruct.com.au>
Sun, 14 Dec 2025 08:37:17 +0000 (17:37 +0900)
The gpio-leds driver requires all GPIOs in a group to be available;
if any GPIO in the group is not available the whole group will not be
created. The hdd_led GPIO is only present after standby power is
enabled, which can prevent other LEDs in the same group from being
created and blocks properly setting 'bmc_ready_noled'.

Move the 'hdd_led' node into a separate gpio-leds group so that other
LEDs are not blocked and the 'bmc_ready_noled' flag can be set
correctly.

Fixes: b5dd16228216 ("ARM: dts: aspeed: clemente: Add HDD LED GPIO")
Signed-off-by: Alex Wang <alex.ts.wang@fii-foxconn.com>
Link: https://patch.msgid.link/20251127-leo-dts-add-shunt-resistor-v2-1-c77dfbfb826c@fii-foxconn.com
[arj: Fix patch subject, add Fixes: tag]
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-clemente.dts

index dfe8f6d0eeef55f5ccd23e258dbed8eec4e00f60..ea1bf6f402bd12bf37a03a1c848d74fb72026c58 100644 (file)
                        gpios = <&gpio0 ASPEED_GPIO(P, 5) (GPIO_ACTIVE_HIGH|GPIO_TRANSITORY)>;
                };
 
-               led-hdd {
+       };
+
+       hdd-leds {
+               compatible = "gpio-leds";
+
+               led-0 {
                        label = "hdd_led";
                        gpios = <&io_expander13 1 GPIO_ACTIVE_LOW>;
                };