]> git.ipfire.org Git - thirdparty/haproxy.git/commitdiff
MINOR: server: disable CLI 'set server ssl' for dynamic servers
authorAmaury Denoyelle <adenoyelle@haproxy.com>
Wed, 19 May 2021 13:00:54 +0000 (15:00 +0200)
committerAmaury Denoyelle <adenoyelle@haproxy.com>
Fri, 18 Jun 2021 14:42:25 +0000 (16:42 +0200)
'set server ssl' uses ssl parameters from default-server. As dynamic
servers does not reuse any default-server parameters, this command has
no sense for them.

src/server.c

index ef80d2b0ffa7485049f344b1c2a55a6f05a7a7ef..4a4c3c8436d7f0b7c26489c0613d50a4357f4ec6 100644 (file)
@@ -4081,6 +4081,11 @@ static int cli_parse_set_server(char **args, char *payload, struct appctx *appct
        }
        else if (strcmp(args[3], "ssl") == 0) {
 #ifdef USE_OPENSSL
+               if (sv->flags & SRV_F_DYNAMIC) {
+                       cli_err(appctx, "'set server <srv> ssl' not supported on dynamic servers\n");
+                       goto out;
+               }
+
                if (sv->ssl_ctx.ctx == NULL) {
                        cli_err(appctx, "'set server <srv> ssl' cannot be set. "
                                        " default-server should define ssl settings\n");