]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
net/rds: Clear reconnect pending bit
authorHåkon Bugge <haakon.bugge@oracle.com>
Tue, 3 Feb 2026 05:57:20 +0000 (22:57 -0700)
committerJakub Kicinski <kuba@kernel.org>
Thu, 5 Feb 2026 04:46:38 +0000 (20:46 -0800)
When canceling the reconnect worker, care must be taken to reset the
reconnect-pending bit. If the reconnect worker has not yet been
scheduled before it is canceled, the reconnect-pending bit will stay
on forever.

Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com>
Signed-off-by: Allison Henderson <allison.henderson@oracle.com>
Link: https://patch.msgid.link/20260203055723.1085751-6-achender@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/rds/connection.c

index 3f26a67f3180405b1c96606af4a620e269dce7e0..4b7715eb2111cd1c64c345df0d700fa1514d634d 100644 (file)
@@ -442,6 +442,8 @@ void rds_conn_shutdown(struct rds_conn_path *cp)
         * to the conn hash, so we never trigger a reconnect on this
         * conn - the reconnect is always triggered by the active peer. */
        cancel_delayed_work_sync(&cp->cp_conn_w);
+
+       clear_bit(RDS_RECONNECT_PENDING, &cp->cp_flags);
        rcu_read_lock();
        if (!hlist_unhashed(&conn->c_hash_node)) {
                rcu_read_unlock();