]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
staging: rtl8723bs: remove unnecessary rtw_bug_check() function
authorNikolay Kulikov <nikolayof23@gmail.com>
Tue, 7 Apr 2026 14:33:26 +0000 (17:33 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 27 Apr 2026 11:01:53 +0000 (05:01 -0600)
Remove the rtw_bug_check() function as it does nothing and always
returns 'true', making any checks on its result meaningless.

Signed-off-by: Nikolay Kulikov <nikolayof23@gmail.com>
Link: https://patch.msgid.link/20260407143622.9767-2-nikolayof23@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8723bs/core/rtw_mlme.c
drivers/staging/rtl8723bs/include/osdep_service.h

index ddfc56f0253dfdffaac72ecc655bd88a0d56ac98..8e9387ad2810576ca3fb6058beeb76a2a9738d46 100644 (file)
@@ -351,9 +351,6 @@ int is_same_network(struct wlan_bssid_ex *src, struct wlan_bssid_ex *dst, u8 fea
        u16 s_cap, d_cap;
        __le16 tmps, tmpd;
 
-       if (rtw_bug_check(dst, src, &s_cap, &d_cap) == false)
-               return false;
-
        memcpy((u8 *)&tmps, rtw_get_capability_from_ie(src->ies), 2);
        memcpy((u8 *)&tmpd, rtw_get_capability_from_ie(dst->ies), 2);
 
@@ -457,11 +454,6 @@ static void update_current_network(struct adapter *adapter, struct wlan_bssid_ex
 {
        struct  mlme_priv *pmlmepriv = &adapter->mlmepriv;
 
-       rtw_bug_check(&pmlmepriv->cur_network.network,
-               &pmlmepriv->cur_network.network,
-               &pmlmepriv->cur_network.network,
-               &pmlmepriv->cur_network.network);
-
        if (check_fwstate(pmlmepriv, _FW_LINKED) && (is_same_network(&pmlmepriv->cur_network.network, pnetwork, 0))) {
                update_network(&pmlmepriv->cur_network.network, pnetwork, adapter, true);
                rtw_update_protection(adapter, (pmlmepriv->cur_network.network.ies) + sizeof(struct ndis_802_11_fix_ie),
@@ -486,8 +478,6 @@ void rtw_update_scanned_network(struct adapter *adapter, struct wlan_bssid_ex *t
        list_for_each(plist, phead) {
                pnetwork = list_entry(plist, struct wlan_network, list);
 
-               rtw_bug_check(pnetwork, pnetwork, pnetwork, pnetwork);
-
                if (is_same_network(&pnetwork->network, target, feature)) {
                        target_find = 1;
                        break;
index 955e8678dc2653eeaaa78ecc93b2828b597a92f8..9392af8589956dfce51f3fb8aba9b70f43728548 100644 (file)
@@ -69,15 +69,6 @@ static inline void flush_signals_thread(void)
 }
 
 #define rtw_warn_on(condition) WARN_ON(condition)
-
-static inline int rtw_bug_check(void *parg1, void *parg2, void *parg3, void *parg4)
-{
-       int ret = true;
-
-       return ret;
-
-}
-
 #define _RND(sz, r) ((((sz)+((r)-1))/(r))*(r))
 
 extern void rtw_free_netdev(struct net_device *netdev);