coverity: #1425888

check return value of getifaddrs()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

diff --git a/src/lxc/network.c b/src/lxc/network.c
index 28d0d8756bc21357b27c19bd530534811c50fa6c..4d17163317fab03f0f816367c06ccb7a50f69931 100644 (file)
--- a/src/lxc/network.c
+++ b/src/lxc/network.c
@@ -1889,6 +1889,7 @@ static const char padchar[] = "0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ";
 
 char *lxc_mkifname(char *template)
 {
+       int ret;
        unsigned int seed;
        FILE *urandom;
        struct ifaddrs *ifa, *ifaddr;
@@ -1900,7 +1901,11 @@ char *lxc_mkifname(char *template)
                return NULL;
 
        /* Get all the network interfaces. */
-       getifaddrs(&ifaddr);
+       ret = getifaddrs(&ifaddr);
+       if (ret < 0) {
+               ERROR("%s - Failed to get network interfaces", strerror(errno));
+               return NULL;
+       }
 
        /* Initialize the random number generator. */
        urandom = fopen("/dev/urandom", "r");