]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s3: libsmb: In SMB1 old protocol - return NT_STATUS_INVALID_NETWORK_RESPONSE if name...
authorJeremy Allison <jra@samba.org>
Mon, 11 May 2020 19:34:10 +0000 (12:34 -0700)
committerKarolin Seeger <kseeger@samba.org>
Thu, 4 Jun 2020 10:32:21 +0000 (10:32 +0000)
Can happen if namelen == 0.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14374

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit b10de0bb64fe022e6b066584013dfb0bdf2ade96)

source3/libsmb/clilist.c

index 4f518339e2bdb83d99a93cea9ad5ef48f828845f..06a45e221f62c3aae3ab8b918cc5c1e68856846f 100644 (file)
@@ -552,7 +552,10 @@ static NTSTATUS cli_list_old_recv(struct tevent_req *req, TALLOC_CTX *mem_ctx,
                        TALLOC_FREE(finfo);
                        return NT_STATUS_NO_MEMORY;
                }
-
+               if (finfo->name == NULL) {
+                       TALLOC_FREE(finfo);
+                       return NT_STATUS_INVALID_NETWORK_RESPONSE;
+               }
                status = is_bad_finfo_name(state->cli, finfo);
                if (!NT_STATUS_IS_OK(status)) {
                        smbXcli_conn_disconnect(state->cli->conn, status);