]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
mm/damon/lru_sort: reset enabled when DAMON start failed
authorSeongJae Park <sj@kernel.org>
Sun, 6 Jul 2025 19:32:06 +0000 (12:32 -0700)
committerAndrew Morton <akpm@linux-foundation.org>
Sun, 13 Jul 2025 23:38:34 +0000 (16:38 -0700)
When the startup fails, 'enabled' parameter is not reset.  As a result,
users show the parameter 'Y' while it is not really working.  Fix it by
resetting 'enabled' to 'false' when the work is failed.

Link: https://lkml.kernel.org/r/20250706193207.39810-6-sj@kernel.org
Fixes: 7a034fbba336 ("mm/damon/lru_sort: enable and disable synchronously")
Signed-off-by: SeongJae Park <sj@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/damon/lru_sort.c

index 4af8fd4a390b662b1ff5f05ce789c4794eee1277..9bd8a1a115e0b3e324c6d69acc96f19ce777c666 100644 (file)
@@ -325,7 +325,7 @@ static int __init damon_lru_sort_init(void)
        int err = damon_modules_new_paddr_ctx_target(&ctx, &target);
 
        if (err)
-               return err;
+               goto out;
 
        ctx->callback.after_wmarks_check = damon_lru_sort_after_wmarks_check;
        ctx->callback.after_aggregation = damon_lru_sort_after_aggregation;
@@ -334,6 +334,9 @@ static int __init damon_lru_sort_init(void)
        if (enabled)
                err = damon_lru_sort_turn(true);
 
+out:
+       if (err && enabled)
+               enabled = false;
        return err;
 }