]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
soc: ti: k3-ringacc: Fix access mode for k3_ringacc_ring_pop_tail_io/proxy
authorSiddharth Vadapalli <s-vadapalli@ti.com>
Fri, 1 May 2026 12:40:54 +0000 (18:10 +0530)
committerNishanth Menon <nm@ti.com>
Fri, 15 May 2026 13:19:37 +0000 (08:19 -0500)
k3_ringacc_ring_pop_tail_io() and k3_ringacc_ring_pop_tail_proxy()
incorrectly use K3_RINGACC_ACCESS_MODE_POP_HEAD instead of
K3_RINGACC_ACCESS_MODE_POP_TAIL. This will result in ring elements being
popped in the reverse order of that which the caller expects. Fix this.

Fixes: 3277e8aa2504 ("soc: ti: k3: add navss ringacc driver")
Cc: stable@vger.kernel.org
Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
Reviewed-by: Hari Prasath Gujulan Elango <gehariprasath@ti.com>
Link: https://patch.msgid.link/20260501124129.362192-1-s-vadapalli@ti.com
Signed-off-by: Nishanth Menon <nm@ti.com>
drivers/soc/ti/k3-ringacc.c

index 7602b8a909b05854bea90673614312aa4a2b5b26..e2ca380812d2985731ae7a4a700703a8c64f0db8 100644 (file)
@@ -1012,7 +1012,7 @@ static int k3_ringacc_ring_pop_head_proxy(struct k3_ring *ring, void *elem)
 static int k3_ringacc_ring_pop_tail_proxy(struct k3_ring *ring, void *elem)
 {
        return k3_ringacc_ring_access_proxy(ring, elem,
-                                           K3_RINGACC_ACCESS_MODE_POP_HEAD);
+                                           K3_RINGACC_ACCESS_MODE_POP_TAIL);
 }
 
 static int k3_ringacc_ring_access_io(struct k3_ring *ring, void *elem,
@@ -1083,7 +1083,7 @@ static int k3_ringacc_ring_pop_io(struct k3_ring *ring, void *elem)
 static int k3_ringacc_ring_pop_tail_io(struct k3_ring *ring, void *elem)
 {
        return k3_ringacc_ring_access_io(ring, elem,
-                                        K3_RINGACC_ACCESS_MODE_POP_HEAD);
+                                        K3_RINGACC_ACCESS_MODE_POP_TAIL);
 }
 
 /*