lib/cache: fix excessive logging regression

Regressed in 29b55ceb426efaa and annoyingly logging e.g.:
> [cache ] [35589.02] stash failed, ret = 1

Example QNAME to trigger this: foo.bar.cloudflare.net

diff --git a/NEWS b/NEWS
index aebf36769f5da5292bfd819e8f27ee2653e5935b..08ac8dfaedd500b7e9d6ac4eec8924d55558b5c3 100644 (file)
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,11 @@
+Knot Resolver 6.4.2 (2026-08-dd)
+================================
+
+Bugfixes
+--------
+- cache: avoid excessive logging introduced in the last release (!1869)
+
+
 Knot Resolver 6.4.1 (2026-07-22)
 ================================
 

diff --git a/lib/cache/api.c b/lib/cache/api.c
index 3e2b99b0f11ad5e18bd3ec1b6abc82fca2a3b03f..5e2fb7e519e1bd0c6e472a18c786eaa160777006 100644 (file)
--- a/lib/cache/api.c
+++ b/lib/cache/api.c
@@ -556,15 +556,13 @@ static ssize_t stash_rrset(struct kr_cache *cache, const struct kr_query *qry,
                return kr_error(EINVAL);
 
        int ret = kr_ok();
-       if (rrset_has_min_range_or_weird(rr, qry)) {
-               ret = kr_error(ERANGE);
+       if (rrset_has_min_range_or_weird(rr, qry))
                goto return_needs_pkt;
-       }
 
        const int wild_labels = rr_sigs == NULL ? 0 :
               knot_dname_labels(rr->owner, NULL) - knot_rrsig_labels(rr_sigs->rrs.rdata);
        if (wild_labels < 0) {
-               ret = kr_error(ERANGE);
+               VERBOSE_MSG(qry, "=> invalid wildcard labels %d\n", wild_labels);
                goto return_needs_pkt;
        }
        const knot_dname_t *encloser = rr->owner; /**< the closest encloser name */
@@ -584,7 +582,7 @@ static ssize_t stash_rrset(struct kr_cache *cache, const struct kr_query *qry,
                        signer_labels = MAX(signer_labels, l);
                }
                if (knot_dname_labels(encloser, NULL) < signer_labels) {
-                       ret = kr_error(ERANGE);
+                       VERBOSE_MSG(qry, "=> invalid wildcard labels %d\n", wild_labels);
                        goto return_needs_pkt;
                }
        }