]> git.ipfire.org Git - thirdparty/haproxy.git/commitdiff
BUG/MINOR: h3: do not report bug on unknown method
authorAmaury Denoyelle <adenoyelle@haproxy.com>
Mon, 30 May 2022 08:18:46 +0000 (10:18 +0200)
committerAmaury Denoyelle <adenoyelle@haproxy.com>
Mon, 30 May 2022 12:30:05 +0000 (14:30 +0200)
Remove an unneeded BUG_ON statement when find_http_meth() returns
HTTP_METH_OTHER.

This fix is necessary to support requests with unusual methods with
DEBUG_STRICT activated. This was detected when browsing with HTTP/3 over
a nextcloud instance which uses PROPFIND method for Webdav.

src/h3.c

index 14ae2c4a2b73213baf3903be6666b1172e7683e0..3ff45ffe1c382b90c95a190a8a9a072edb85a8cf 100644 (file)
--- a/src/h3.c
+++ b/src/h3.c
@@ -321,7 +321,6 @@ static int h3_headers_to_htx(struct qcs *qcs, struct ncbuf *buf, uint64_t len,
                sl->flags |= HTX_SL_F_BODYLESS;
 
        sl->info.req.meth = find_http_meth(meth.ptr, meth.len);
-       BUG_ON(sl->info.req.meth == HTTP_METH_OTHER);
 
        if (isttest(authority))
                htx_add_header(htx, ist("host"), authority);