]> git.ipfire.org Git - thirdparty/u-boot.git/commitdiff
dfu: scsi: don't call scsi_scan()
authorCaleb Connolly <caleb.connolly@linaro.org>
Fri, 11 Apr 2025 15:03:36 +0000 (17:03 +0200)
committerTom Rini <trini@konsulko.com>
Tue, 24 Jun 2025 13:54:51 +0000 (07:54 -0600)
Calling scsi_scan() results in all the block devices (and EFI block
devices) being destroyed and re-created. This breaks the EFI filesystem
drivers during capsule update.

Remove the call, since boards really should be calling scsi_scan()
themselves during board_init().

Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>
Link: https://lore.kernel.org/r/20250411-b4-qcom-capsule-update-improvements-v2-3-27f6b2fcc4a9@linaro.org
Signed-off-by: Casey Connolly <casey.connolly@linaro.org>
drivers/dfu/dfu_scsi.c

index 7ec34a8f7e3171ae3a8ff56e112c2dbfc5b2fc29..d99b05d23ac59cf40002a05118de678ba372e5dd 100644 (file)
@@ -342,11 +342,6 @@ int dfu_fill_entity_scsi(struct dfu_entity *dfu, char *devstr, char **argv, int
                        return -EINVAL;
        }
 
-       if (scsi_scan(false)) {
-               pr_err("Couldn't init scsi device.\n");
-               return -ENODEV;
-       }
-
        ret = find_scsi_device(dfu->data.scsi.lun, &scsi);
        if (ret < 0) {
                pr_err("Couldn't find scsi device no. %d.\n", dfu->data.scsi.lun);